[Partial Translate] Update label resizing logic to remove empty space

Previous logic relied on using the preferred size of bubble view housing
the language names, as this is the one element that can dynamically
change in width as languages are updated. However, this could be 
inaccurate to the actual width of the bubble, and resulted in empty 
vertical space in some text-language combinations due to too much height
being allocated to the text label.
The root cause is that the |padding_view| in |translate_view_| always 
has a preferred width of 0, and so the preferred width of 
|tab_view_top_row_| is less than the actual bubble width when the latter
exceeds the bubble's minimum possible width. The bubble's minimum width 
is determined by the new ComputeLargestViewStateWidth. Thus, this min 
width can be used as the source of truth when the actual width of 
|padding_view| is greater than 0, and the preferred width of 
|tab_view_top_row_| can be used otherwise.

Bug: 1374038
Change-Id: I18cb0b03ea6dd5a0265cf5926567b547ab21f9e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4038864
Reviewed-by: Basia Zimirska <basiaz@google.com>
Commit-Queue: Anthony Cui <cuianthony@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1077800}
2 files changed
tree: 7ba0eac4948b170820089ac0331edf3b5d55d064
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.