commit | f9145d216f1c09f235a530fba70c38f4a9d01daf | [log] [tgz] |
---|---|---|
author | Anthony Cui <cuianthony@google.com> | Thu Dec 01 02:30:48 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Dec 01 02:30:48 2022 |
tree | 7ba0eac4948b170820089ac0331edf3b5d55d064 | |
parent | 00a2e048ca2412f970230908538d28395ad956f3 [diff] |
[Partial Translate] Update label resizing logic to remove empty space Previous logic relied on using the preferred size of bubble view housing the language names, as this is the one element that can dynamically change in width as languages are updated. However, this could be inaccurate to the actual width of the bubble, and resulted in empty vertical space in some text-language combinations due to too much height being allocated to the text label. The root cause is that the |padding_view| in |translate_view_| always has a preferred width of 0, and so the preferred width of |tab_view_top_row_| is less than the actual bubble width when the latter exceeds the bubble's minimum possible width. The bubble's minimum width is determined by the new ComputeLargestViewStateWidth. Thus, this min width can be used as the source of truth when the actual width of |padding_view| is greater than 0, and the preferred width of |tab_view_top_row_| can be used otherwise. Bug: 1374038 Change-Id: I18cb0b03ea6dd5a0265cf5926567b547ab21f9e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4038864 Reviewed-by: Basia Zimirska <basiaz@google.com> Commit-Queue: Anthony Cui <cuianthony@chromium.org> Cr-Commit-Position: refs/heads/main@{#1077800}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.