Google Git
Sign in
chromium / chromium / src / f96ef6029ed71b666674056388126d829efc3a66
commitf96ef6029ed71b666674056388126d829efc3a66[log] [tgz]
authorSalvador Guerrero <salg@google.com>Thu Nov 03 16:20:50 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Nov 03 16:20:50 2022
treedba2b926125bccc04386914818f8cc1328f34449
parent21a532d998a0480c7559419a9d0ad404e5f3f66e [diff]
Fixed reader mode CPA disappearing on startup

There are some cases where we query for CPA signals twice for the same
page load, for example on startup.

Rate limiting on ReaderModeManager assumed that the signal would be
queried once per page load, so the second time it'll return
false and the reader mode action will disappear.

This CL adds a postTask to ReaderModeActionProvider to wait to notify
ReaderModeManager of the shown action, that way the second call won't
be rate limited.

Bug: 1380093
Change-Id: I6d82bdfdafd8c9beedb158a2f843330d9a7679ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3998724
Commit-Queue: Salvador Guerrero Ramos <salg@google.com>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1067052}
2 files changed
tree: dba2b926125bccc04386914818f8cc1328f34449
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.