commit f9740a351a0b1d24ea191ff7d4109f1ede014816
author Ashley Newson <ashleynewson@chromium.org> Fri Aug 09 16:59:03 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Aug 09 16:59:03 2024
tree 8e7e402ea3df021b5403b0954ee613b0b77a5405
parent 904dd353f5b886d9d2da2ef8952963cd89a206f8

Exercise real init logic in BlindSignMessageAndroidImpl tests

This change introduces refinements to the unittests for
BlindSignMessageAndroidImpl.

The primary modification is to use an test-replacible factory for
IpProtectionAuthClients instead of directly setting the
IpProtectionAuthClient in the BlindSignMessageAndroidImpl class. This
avoids manually driving internal initialization in tests, instead
exercising the real code paths.

Tests no longer need to drive private non-test methods. As such, the
class no longer specifies the tests as a friend and ForTesting methods
have been made public.

Additional improvements:

- The example protos used in tests were previously derived from
  unparsable strings, and their subsequent use was undefined
  behavior. The protos have been replaced with well-defined values.
- Use StrictMock instead of individually using Times(0) in EXPECT_CALL.
- In RetryCreateConnectedInstanceOnNextRequestfServiceDisconnected, use
  the same request type for both halves of the test.
- Replace some ASSERT_TRUEs with EXPECT_*s.
- Cleaned up some obsolete includes and using directives.
- Refactor some using aliases.
- Misc style alterations.

Bug: b:331619233
Change-Id: I33b784a820ee89f23f1dff7a09ce3379ca452883
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5756878
Reviewed-by: Etienne Dechamps <edechamps@google.com>
Commit-Queue: Ashley Newson <ashleynewson@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1339697}