Have chrome_desktop_report_request_helper.cc use SecKeychain directly chrome_desktop_report_request_helper.cc relies on `AppleKeychain` being implemented in terms of the deprecated `SecKeychain` APIs and providing access to the underlying `SecKeychainItemRef` to use it to make direct `SecKeychain` calls. `AppleKeychain` will soon switch to wrapping the `SecItem` APIs which do not support returning `SecKeychainItemRef` objects. chrome_desktop_report_request_helper.cc will need to be updated to use `SecItem` APIs independently. This work is tracked by b/405511914. Until then, having it use `SecKeychain` directly unblocks migrating `AppleKeychain` to `SecItem`. Once everything is updated to `SecItem` it may be possible to re-unify its use with `AppleKeychain`. Bug: 395659797, b/405511914 Change-Id: I6a6a2100871353b4f21b108f75e5f89f329eedef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6443471 Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org> Commit-Queue: Mark Rowe <markrowe@chromium.org> Cr-Commit-Position: refs/heads/main@{#1445271}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.