Google Git
Sign in
chromium / chromium / src / f9daad84b0b1924bff228b7624b57af2b034c4ee
commitf9daad84b0b1924bff228b7624b57af2b034c4ee[log] [tgz]
authorAli Juma <ajuma@chromium.org>Thu Apr 20 17:51:31 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Apr 20 17:51:31 2023
treefc650e99045d94558ecae8353ec46bdfee6faf57
parent01b72a567fed0e1dc4548ccba84ca7f3506019bc [diff]
[CodeHealth] Remove NotificationObserver use in PageLoadMetricsBrowserTest

This uses a TestNavigationObserver rather than relying on a
NOTIFICATION_NAV_ENTRY_COMMITTED notification.

This CL is part of a larger effort towards removing NotificationSerivce.
See https://docs.google.com/document/d/1FC8Hkva34vKtCr57cz6Yw5H_Dj0Fq1sfY2yr7fh2ryA/edit

Bug: 1174760
Change-Id: I093ed5dfe6d8cc96434b37a9ea0347ae8bbe3767
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4451446
Reviewed-by: Nicolás Peña <npm@chromium.org>
Commit-Queue: Ali Juma <ajuma@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1133221}
1 file changed
tree: fc650e99045d94558ecae8353ec46bdfee6faf57
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.