commit | fa2913135fb37708954c4718cd613784b32fb806 | [log] [tgz] |
---|---|---|
author | Antonio Gomes <tonikitoo@igalia.com> | Fri Mar 01 18:27:28 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Mar 01 18:27:28 2019 |
tree | 2b3d8d062b5ba377b7076eac33db0788ffc424c1 | |
parent | 05d8f300b054afea95c9d1bd91a2a5f45fedf175 [diff] |
Remove never-reached if block in StyleSheetContents::WrapperDeleteRule |StyleSheetContents::import_rules_| is of type HeapVector<Member<StyleRuleImport>>. Its members will always resolve |import_rules_[index]->IsFontFaceRule()| to false (once StyleRuleBase::IsImportRule() is the one that resolves to true. This CL removes the if-block that checks that altogether, allowing the removal of the remaining DEFINE_STYLE_RULE_TYPE_CASTS occurrence. Note: This was caught because trying to use To<StyleRuleFaceRule> failed to compile. ../../third_party/blink/renderer/platform/wtf/casting.h:102:10: error: non-const lvalue reference to type 'blink::StyleRuleFontFace' cannot bind to a value of unrelated type 'blink::StyleRuleImport' return static_cast<Derived&>(from); ^ ~~~~ R=jbroman@chromium.org CC=​blink-reviews-vendor@chromium.org BUG=891908 Change-Id: I6bbf992b3654601a50fc68b18961de79899d5284 Reviewed-on: https://chromium-review.googlesource.com/c/1496056 Reviewed-by: Jeremy Roman <jbroman@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#636879}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .