Google Git
Sign in
chromium / chromium / src / 70589d0c6e8eb005033fdc2b7bbb5f783ffc427f
commit70589d0c6e8eb005033fdc2b7bbb5f783ffc427f[log] [tgz]
authorLukasz Anforowicz <lukasza@chromium.org>Thu Jul 22 23:48:58 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jul 22 23:48:58 2021
tree4f98ff92bfba0d1624f6ccc591c380b8f400e602
parent10a1360bfbed628c33dc7e002b43bc2c3e38828f [diff]
Fix how ContentScriptTracker handles about:blank in <webview>.

The CL fixes how ContentScriptTracker detects content script injection
into an about:blank frame when its parent frame has finished loading
before the `addContentScripts` GuestView API was called.

After https://crrev.com/c/2986805 (i.e. even before this CL) the
`addContentScripts` call would trigger a
ContentScriptTracker::WillUpdateContentScriptsInRenderer notification.
The reason this didn't work end-to-end, is that the
DoContentScriptsMatch helper function in content_script_tracker.cc
wouldn't realize that there are GuestView content scripts present.

After this CL tweaks DoContentScriptsMatch to account for GuestView
content scripts, we can also remove
WebViewGuest::ReadyToCommitNavigation, because 1) the old
MarkIsolatedWorldsAsRequiringSeparateURLLoaderFactory call and 2) the
old ReadyToCommitNavigationWithGuestViewContentScripts call are both now
covered by the processing done in the regular, non-GuestView-specific
ContentScriptTracker::ReadyToCommitNavigation.

Bug: 982361
Change-Id: I8c67c6afe6e28093ae910c4f547961de68a7bd35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3021539
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#904545}
5 files changed
tree: 4f98ff92bfba0d1624f6ccc591c380b8f400e602
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.