Google Git
Sign in
chromium / chromium / src / fab3958229dcefdba51a52da2f36c58ed4e4ea30
commitfab3958229dcefdba51a52da2f36c58ed4e4ea30[log] [tgz]
authorBrando <brandosocarras@google.com>Wed Dec 14 18:35:55 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Dec 14 18:35:55 2022
tree7655ef02f40ad78acc91c75377545c38d2b09e21
parent0c37d5ab6093047fed901d58fcaa16aacfe60392 [diff]
[Fast Pair] Stop GATT connect timeout only if correct service discovered

The GATT connection timeout timer stops when GattDiscoveryCompleteForService is called from the adapter if the service discovered is the Fast Pair service for the device associated with the FastPairGattServiceClientImpl which the function belogn.

This function is called for every observing the adapter, regardless of whether the service discovered belongs to the device to which the client is associated, so this is checked inside of the aforementioned function.

The call to stop the timer is moved inside of the if branch checking this condition from its erroneous position outside of it.

      Initial pair was successfully completed on DUT. Given that the
      GATT client is fast pair protocol agnostic, this is sufficient
      evidence that the change doesn't affect the GATT connection.

Test: unit tests in this CL and test on DUT:
Fixed: b/262270537
Change-Id: Ifdd684a0fe1b55eaca4f37dc9d774e3a3a49053e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4099546
Reviewed-by: Juliet Lévesque <julietlevesque@google.com>
Commit-Queue: Brando Socarras <brandosocarras@google.com>
Cr-Commit-Position: refs/heads/main@{#1083215}
2 files changed
tree: 7655ef02f40ad78acc91c75377545c38d2b09e21
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.