Google Git
Sign in
chromium / chromium / src / fb06de7c7cd46de7e92e8e1150b9b0f7550ceddd
commitfb06de7c7cd46de7e92e8e1150b9b0f7550ceddd[log] [tgz]
authorconniekxu <conniekxu@chromium.org>Sat Jan 08 00:52:07 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Sat Jan 08 00:52:07 2022
tree9fe57282cd2e556a279647d376d19dfc4fa9bb94
parent77e76a46cfb4f160016a120248e0b9d628e719ce [diff]
capture_mode: Don't show capture UIs on 3-second count down finished

The issue is that after 3-second count down is finished, the capture
mode bar shows up transiently before the start of video recording when
the session is started by projector. It's because of the
CaptureModeSession::OnWaitingForDlpConfirmationEnded is also called at
the end of the 3-second count down.
To fix this issue, this CL renames the parameter for the method to
indicate whether bring back capture mode UIs or not.

Test: manual
Change-Id: I11e6cc3485488cb4f6cf0504045fe74ca01e514e
Fixed: 1284831
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3370819
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Connie Xu <conniekxu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#956749}
3 files changed
tree: 9fe57282cd2e556a279647d376d19dfc4fa9bb94
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.