commit fb671babdc29f773731e4bc92439b14da172b228
author Colin Blundell <blundell@chromium.org> Mon Jul 09 14:57:28 2018
committer Commit Bot <commit-bot@chromium.org> Mon Jul 09 14:57:28 2018
tree 03bd98134f6709ee81581d687e23a845d8170f1c
parent e2f52f3c9f8cc8ae5013e395325bb385707b3164

GaiaCookieManagerService: Change semantics of ListAccounts()

GaiaCookieManagerService::ListAccounts() takes in out-params to
populate with the current cached state of the accounts and returns a
bool indicating whether the cached state is valid. Its contract
specifies that if the returned bool is false, the out-params should be
ignored.

This CL changes the semantics of GaiaCookieManagerService::ListAccounts()
to always populate its out-parameters, even if its cached state is
stale. We verified manually that all current clients of this method
guard the usage of the out-params via a check that the returned bool is
true, so this semantic change will not affect any existing clients.

The reason for making this semantic change is that there is an
upcoming consumer that wants to have synchronous access to the
latest cached state of the accounts, regardless of whether that state
is stale.

Bug: 859882
Change-Id: I47fc55bb2fad6caf9a2fc5911c8f60f97e4bc5a6
Reviewed-on: https://chromium-review.googlesource.com/1128892
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#573307}