Fix post-filling logic in the renderer

This CL fixes two problems:

- AutofillAgent::ApplyFieldsAction() uses FormFieldData::host_form_id in
  order to get the owning forms of fields, whereas this information is
  populated before the filling operation and many other operations that
  can trigger JS happen, meaning that this information is not
  necessarily accurate (and is probably one cause of some crashes)

- The method also uses `fields` and `filled_fields_ids` inconsistently.
  `fields` shouldn't be used after calling
  `form_util::ApplyFieldsAction()` because it is not representative of
  what fields were actually filled.

The CL fixes this by introducing a map `filled_fields_and_forms ` that maps each "filled" field to its actual updated owning form. and it uses
this map everywhere after calling the filling function.

Note that this makes `FormFieldFata::FillData::host_form_id_` obsolete
but the CL doesn't remove it since it has some iOS references.

Bug: 40947729, 392907891
Change-Id: I069bcc5f42747381c86de6898f0d8e2db8b0eee5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6218588
Reviewed-by: Christoph Schwering <schwering@google.com>
Commit-Queue: Jihad Hanna <jihadghanna@google.com>
Cr-Commit-Position: refs/heads/main@{#1418081}
1 file changed
tree: 9273a43fb16103770bd0599285946eb199c595ad
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.