commit | fbf06e2d96f8625f4ed1b10d688c8c5a04ec7263 | [log] [tgz] |
---|---|---|
author | Sean Kau <skau@chromium.org> | Wed Jan 18 20:14:00 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Jan 18 20:14:00 2023 |
tree | a67df47260bea6cf7278fce52c655c86d2c309d3 | |
parent | 9aaab6b30dda4a96769389acadf68daaa5310bd3 [diff] |
Reland "Rewrite WallpaperColorCalculator with a Callback" This reverts commit 1e1b18171fd6a21cb9a04feac389f9b53e668df8. Reason for revert: Fix include path that landed with previous change. Original change's description: > Revert "Rewrite WallpaperColorCalculator with a Callback" > > This reverts commit 6223bc43bc975d53454056fcdef964beee3d5da8. > > Reason for revert: > LUCI Bisection identified this CL as the culprit of a build failure. See the analysis: https://luci-bisection.appspot.com/analysis/b/8791606956156824721 > > Sample failed build: https://ci.chromium.org/b/8791606956156824721 > > If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2Fluci-bisection.appspot.com%2Fanalysis%2Fb%2F8791606956156824721&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F4164138 > > Original change's description: > > Rewrite WallpaperColorCalculator with a Callback > > > > Removes the Observer interface in favor of a callback since only one > > client receives the result. Rewrite test to use RunLoop and > > cleanup as appropriate. > > > > Bug: b:258750361 > > Change-Id: I719bdd1c16d0158f5ce2553725156c56fa9a5c53 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4164138 > > Reviewed-by: Jeffrey Young <cowmoo@google.com> > > Commit-Queue: Sean Kau <skau@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1093985} > > > > Bug: b:258750361 > Change-Id: I696202d7c2acfcacb0fda54ad292d9e42719a0be > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4177691 > Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> > Reviewed-by: Sean Kau <skau@chromium.org> > Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> > Reviewed-by: Jeffrey Young <cowmoo@google.com> > Commit-Queue: Sean Kau <skau@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1093991} Bug: b:258750361 Change-Id: I3df4792bd6793b25ff08c5e77371fea01b4b630d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4177955 Reviewed-by: Jeffrey Young <cowmoo@google.com> Commit-Queue: Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/main@{#1094036}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.