commit | fbf3f1850ace4f195f1e32c640c19fe9f32ab8e4 | [log] [tgz] |
---|---|---|
author | Julie Jeongeun Kim <jkim@igalia.com> | Wed Sep 16 02:22:34 2020 |
committer | Commit Bot <commit-bot@chromium.org> | Wed Sep 16 02:22:34 2020 |
tree | 5f280d9c71cac208774f5ba27ac6967268270eed | |
parent | 174f78b58f3d598cc13855711d116a06ca95824e [diff] |
[printing] Use uint32_t for a page number and counts This CL is a follow-up CL of converting PrintHostMsg_DidGetPrintedPagesCount to mojo [1] and it updates the type for the page number and counts with uint32_t as it couldn't have a negative value. It keeps using int for JNI and dictionary values and uses 'base::checked_cast<int>' to convert uint to int. In order to make sure that the value is in the range to cast, this change also adds the maximum limit for the page number and counts and checks the value before passing it to JNI or dictionary. Given that the previous type is int, the maximum limit is std::numeric_limits<int>::max(). [1] https://crrev.com/c/2326857 Bug: 1008939 Change-Id: I5c86514be4e7d549f888c9623136078a3b0c88c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351580 Reviewed-by: Bo <boliu@chromium.org> Reviewed-by: Andrey Kosyakov <caseq@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#807307}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.