Google Git
Sign in
chromium / chromium / src / fbf47dae36eedbe09c210f1e2ba1de3b6a469f50
commitfbf47dae36eedbe09c210f1e2ba1de3b6a469f50[log] [tgz]
authorNick Diego Yamane <nickdiego@igalia.com>Tue Oct 29 19:43:54 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Oct 29 19:43:54 2024
tree1d870ad5c0183a34cac526a4d766dc12228becf4
parent52b6f1ce0943f3d70098116a03919c73c46cb7a2 [diff]
tabdrag: fix drag offset miscalc when detaching from maximized windows

The fix consists of not overwriting the full (previously calculated)
drag offset, in TabDragController::AdjustBrowserAndTabBoundsForDrag.
Instead, it only adjusts its X coordinate, which makes even more sense
in the end as that function is actually about horizontal alignment.

Also, the (reposition-only) SetBounds call in that very same function is
now restricted to when the platform does support global screen window
positioning.

Additionally, a minor cleanup is done by re-using
PlatformProvidesAbsoluteWindowPositions instead of replicating its
implementation in CreateBrowserForDrag.

R=max@igalia.com, tbergquist

Bug: 375876206
Test: Manually using both KWin and (wip) Mutter xdg-toplevel-drag protocol impl
Change-Id: I0352ef4b3cfdc4e483fc1a3cf2fde4e85e82dbe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5969493
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Max Ihlenfeldt <max@igalia.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1375447}
1 file changed
tree: 1d870ad5c0183a34cac526a4d766dc12228becf4
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.