commit | fc192b26635c29586024f9c8ca2678a987b8c52d | [log] [tgz] |
---|---|---|
author | Florian Jacky <fjacky@google.com> | Mon Apr 07 10:42:56 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Apr 07 10:42:56 2025 |
tree | 3cf920446f5d35bff8849ffaee69c346c89a81b4 | |
parent | 438b276f5f28c082cef8ad772f2feb0de05606f2 [diff] |
Fix PermissionPromptSurvey to trigger upon tab closure. Tab closure causes active prompts to be ignored, which is a supported prompt action trigger of the permission prompt survey. However, tab closure causes a tab to be destructed, which causes the WebContents to have Visibility::HIDDEN. The HaTS service checks that a WebContents is visible if a survey should be triggered for a particular WebContents, hence tab closure currently won't ever trigger a HaTS survey. To support this functionality, we instead launch the survey for the last active browser when the trigger is run. This requires some HaTS service plumbing, since the permission prompt survey supports custom invitations on Clank, which is an experimental feature for which we still need to make a decision on, and hence should not remove support for at this point. (cherry picked from commit fe4de1fec88827531d3f82b596eb2814cc8ab85b) Bug: 407953263 Fixed: 408368155 Change-Id: I5f5bb48b442b620e6b0faec47f160be9e2af9ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6425143 Commit-Queue: Florian Jacky <fjacky@chromium.org> Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Alex Ilin <alexilin@chromium.org> Cr-Original-Commit-Position: refs/heads/main@{#1442057} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6433894 Cr-Commit-Position: refs/branch-heads/7103@{#343} Cr-Branched-From: e09430c64983fc906f37a9f7e6806275c9b67b86-refs/heads/main@{#1440670}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.