Google Git
Sign in
chromium / chromium / src / fc67119c30aa41fddb48a0850866a710fb221ab8
commitfc67119c30aa41fddb48a0850866a710fb221ab8[log] [tgz]
authorBenjamin Williams <bwwilliams@google.com>Tue Jan 17 18:40:17 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jan 17 18:40:17 2023
tree6257e43f7b92351cccf6d235903cced6d90461d6
parentcbf2e954ffae8b38a1cf754d18af2e61c40ddccb [diff]
[iOS] Enable Smart Sorting to add/remove destinations.

This change enables the Smart Sorting algorithm to support adding new
destinations, or removing existing destinations, by introducing the
method `runHistoryDiagnostic`.

`runHistoryDiagnostic` is called before the Smart Sorting algorithm is
run and detects whether or not the destinations list has changed between
presentations of the overflow menu.

When `runHistoryDiagnostic` detects the carousel and ranking differ, it
ensures the ranking gets updated to reflect the items currently in the
carousel.

This change will be gated behind the feature
`kSmartSortingPriceTrackingDestination`, as the Price Tracking
destination is the first new destination (with Smart Sorting) to be
added to the overflow menu.

Feature demo (video):
https://drive.google.com/open?id=1Qs3vTh3Lz_GB7PcdrCuQEisTJ5xmYvCw&authuser=0&resourcekey=0-29BLMhhJcj5UCaFOOrjCRg&usp=drive_link

Change-Id: I9fc4943708a466869d652db55fc3e51385b83dc7
Bug: 1405265
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4133648
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Benjamin Williams <bwwilliams@google.com>
Cr-Commit-Position: refs/heads/main@{#1093416}
10 files changed
tree: 6257e43f7b92351cccf6d235903cced6d90461d6
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.