Google Git
Sign in
chromium / chromium / src / fcadaf152de89129493ccee087e0fb67f0a4fa2a
commitfcadaf152de89129493ccee087e0fb67f0a4fa2a[log] [tgz]
authorLijin Shen <lazzzis@google.com>Wed May 18 21:10:46 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 18 21:10:46 2022
tree3678ec8117df42ff8d1dbbc618c5ff2e2d56cc07
parente799344f048a8e4c1e7d008aca455042d1c497b1 [diff]
Reland "Refactor return-to-home to use new Back Press API"

Reland: Set a default value for the back press handler
during initialization so that it will not be null by default.
Some tests are asserting that should not be null and query back
press state before layout / tab model is updated.

If a tab is opened from start surface and the tab is unable to be
navigated back further, then the back press should trigger the overview/start surface when back press is performed.

The new handler listens to layout state change and tab selected change
to know if the selected tab meets the requirements above.

Bug: 1279941, 1326497
Change-Id: Ie3ad99563660c73c507be25ae5ee2898da547c29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3652242
Reviewed-by: Xi Han <hanxi@chromium.org>
Commit-Queue: Lijin Shen <lazzzis@google.com>
Reviewed-by: Theresa Sullivan <twellington@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1004965}
7 files changed
tree: 3678ec8117df42ff8d1dbbc618c5ff2e2d56cc07
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.