Google Git
Sign in
chromium / chromium / src / fcd670349f4d6d42a15acc13e5499608ee98854b
commitfcd670349f4d6d42a15acc13e5499608ee98854b[log] [tgz]
authorCamillia Smith Barnes <cammie@chromium.org>Tue Apr 01 00:28:31 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Apr 01 00:28:31 2025
tree633638e6373989a67b000a91258e93d773eda840
parentf37072578e92ec3b57c4a21bc225a67fdac24279 [diff]
Shared Storage: Make << escape SharedStorageEventParams serialized_data

We update the operator<< overload for SharedStorageEventParams so that
it escapes SharedStorageEventParams::serialized_data, as
serialized_data is not necessarily valid UTF-8. Moreover, some of
the bytes in serialized_data may be interpreted as ASCII control
characters, which can end up overwriting other parts of the struct
that are supposed to be serialized to the ostream by <<.

Hence, we now escape the serialized data when used by <<. At this
point, this is a cosmetic change that only affects tests, making it
easier to debug them, since values of SharedStorageEventParams
will now serialize to the terminal more intuitively when they don't
meet expectations.

Bug: 401011862
Change-Id: Iad117047e7b1b843c4d8059f8230a454c4985353
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6417209
Commit-Queue: Cammie Smith Barnes <cammie@chromium.org>
Reviewed-by: Yao Xiao <yaoxia@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1440655}
3 files changed
tree: 633638e6373989a67b000a91258e93d773eda840
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.