Google Git
Sign in
chromium / chromium / src / fd08fa82757dc675ba24792d04d93807d4ee849d
commitfd08fa82757dc675ba24792d04d93807d4ee849d[log] [tgz]
authorRyan Sultanem <rsult@google.com>Wed Dec 07 17:04:56 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Dec 07 17:04:56 2022
treed77486e9f3a8e3ff20c14d3fcb8bd1b21e3e4796
parent991a0ebb5cad76414626f0e1423638fb64511d39 [diff]
Protect GetLoadedProfiles() profiles that uses KeyedServices

With the active experiment `kSystemProfileSelectionDefaultNone` crashes
can appear when getting keyedservices without checking their validity,
since System Profile now instantiates very few needed KeyedServices.

A common pattern is to get all active profiles through
`ProfileManager::GetLoadedProfiles()` which might return the System
Profile if the ProfilePicker was instantiated once at least during a
session. Since the call to the profile list  can be totally non service
related, this CL adds protection to all of those calls that are followed
by getting a KeyedService.

Bug: 1284664, 1395198
Change-Id: Ifd35c2480c47539a2007c54e8d137a7f621e6fc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4085089
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Ryan Sultanem <rsult@google.com>
Cr-Commit-Position: refs/heads/main@{#1080381}
9 files changed
tree: d77486e9f3a8e3ff20c14d3fcb8bd1b21e3e4796
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.