Google Git
Sign in
chromium / chromium / src / fd1f9d6b3d5495706ea89e24847d9d10add9f73e
commitfd1f9d6b3d5495706ea89e24847d9d10add9f73e[log] [tgz]
authorAntonio Rivera <antoniori@google.com>Thu Jun 05 19:45:36 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Jun 05 19:45:36 2025
treec8a6f54207b5f6ac829d3b839de372f330bded8e
parent9475df04c92b157cfaba0cbd24c489d5429db90c [diff]
Add logging in chromecast/starboard code.

This logging covers two scenarios:
1. When a MIME type is unsupported by starboard, it's helpful to LOG the
   exact MIME string
2. When something subscribes to or unsubscribes from
   CastStarboardApiAdapter, it is helpful to log the address. This
   way,if something isn't unsubscribing we can see which subscribers
   are remaining (by matching subscribe and unsubscribe calls). So far
   I have not seen issues with this, but if something doesn't
   unsubscribe it could cause shutdown delays for the cast runtime.

Test:
Will cast to a 3P TV. Functionality should not change here, only
logging.

Bug: None
Change-Id: I198b1d2315f50374e9051fd8aed47336fb53f2b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6576704
Commit-Queue: Antonio Rivera <antoniori@google.com>
Reviewed-by: Shawn Quereshi <shawnq@google.com>
Cr-Commit-Position: refs/heads/main@{#1470139}
6 files changed
tree: c8a6f54207b5f6ac829d3b839de372f330bded8e
  1. .github/
  2. android_webview/
  3. apps/
  4. ash/
  5. base/
  6. build/
  7. build_overrides/
  8. buildtools/
  9. cc/
  10. chrome/
  11. chromecast/
  12. chromeos/
  13. codelabs/
  14. components/
  15. content/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .git-blame-ignore-revs
  60. .gitallowed
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. CPPLINT.cfg
  75. CRYPTO_OWNERS
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. SECURITY_OWNERS
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.