[Sync] Notify observers when data types stopped due to preconditions

Prior to this CL, OnSingleDataTypeWillStop() ignored any failures which
are already in DataTypeStatusTable, which was supposed to detect new
failures only. But DataTypePreconditionChanged() updates the table first
and only then stops the data type (which will eventually call
OnSingleDataTypeWillStop), so in practice it's a new failure which is
ignored, hence no reconfiguration is happening and observers are not
notified about the changes.

This CL also fixes data type precondition update code path because it
could start DataTypeManager configuration before the sync engine is
initialized (and hence violate some DCHECKs). Now any precondition
changes are ignored if data type manager is stopped.

Clearing metadata for stopped types is also moved to ModelLoadManager
similar to disabled types.

Bug: 1491071
Change-Id: Ib43c87464f51dee2d1c825abfc79248d4b3d2796
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4931489
Reviewed-by: Ankush Singh <ankushkush@google.com>
Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Rushan Suleymanov <rushans@google.com>
Cr-Commit-Position: refs/heads/main@{#1209352}
5 files changed
tree: 74652770f02ef7f9975c57bdbd4fe96cbc2ed086
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.