[iOS] Handle reload transitions with null items in SafeBrowsingTabHelper

It is rare but possible for a WebStatePolicyDecider to receive a
reload transition while both the current and pending navigation
items are null.

While steps to reproduce are not known, these may be cases where
WebKit incorrectly labels a navigation as being of type
WKNavigationTypeReload.

In this situation, SafeBrowsingTabHelper tries to check if the
item being reloaded has an associated UnsafeResource, but this leads
to crash since the item is null.

This CL fixes the crashes by making SafeBrowsingTabHelper check
whether the item is null before checking if it has an UnsafeResource.

Bug: 1208098
Change-Id: Ic5a4bbcd30bc198dccfdf3f5e81b0a87fae10200
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2889676
Commit-Queue: Ali Juma <ajuma@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#882090}
2 files changed
tree: 34a08fc302aefb7633d9e9540639e558b2ac195b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. trace_layout_test_http_tests_css_vertical-align-baseline-after-image-load-2.html_2021-05-12-08-55-49.json
  78. trace_layout_test_http_tests_css_vertical-align-baseline-after-image-load-2.html_2021-05-12-09-14-09.json
  79. trace_layout_test_http_tests_css_vertical-align-baseline-after-image-load-2.html_2021-05-12-09-29-46.json
  80. trace_layout_test_http_tests_css_vertical-align-baseline-after-image-load-2.html_2021-05-12-09-33-24.json
  81. trace_layout_test_http_tests_css_vertical-align-baseline-after-image-load-2.html_2021-05-12-09-51-23.json
  82. trace_layout_test_http_tests_css_vertical-align-baseline-after-image-load-2.html_2021-05-12-09-53-25.json
  83. trace_layout_test_http_tests_css_vertical-align-baseline-after-image-load-2.html_2021-05-12-09-57-49.json
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.