Google Git
Sign in
chromium / chromium / src / fd59c17d66a5acb8fedce515696a2e394c4986f6
commitfd59c17d66a5acb8fedce515696a2e394c4986f6[log] [tgz]
authorJoe Downing <joedow@google.com>Tue Jun 13 19:37:06 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Jun 13 19:37:06 2023
tree59d6caa7d03d3f0d2b12e765c671f6f966989b0c
parent6ce2a529a8619d35c23542c0df460b1ddc84ae4a [diff]
Addressing a Linux crash in WebrtcDataStreamAdapter::InvokeOpenEvent

The top crash report for the Linux host appears to be a race condition
between WebrtcDataStreamAdapter::Start() being called (where the
event_handler_ member is set) and the InvokeOpenEvent() callback being
run which is posted from OnStateChange() which is handling an event from
|channel_|.

The stack trace doesn't have any info to indicate which data channel was
being opened so but the crash to user ratio is pretty close to 1:1 so I
think it's truly a race condition and not a specific code path.

Bug: 1454494
Change-Id: Id097c167c55f91c3a25a2b61c9805b83e671a5c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4609093
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1157125}
2 files changed
tree: 59d6caa7d03d3f0d2b12e765c671f6f966989b0c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.