Google Git
Sign in
chromium / chromium / src / fd75daaa5d7a3cf424cfaf4572ecfa305b95d238
commitfd75daaa5d7a3cf424cfaf4572ecfa305b95d238[log] [tgz]
authorDustin J. Mitchell <djmitche@chromium.org>Thu Sep 12 14:39:43 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Sep 12 14:39:43 2024
treea0578a12758ccab6e6ef4d07eb6ed2fade9c3b8f
parent36712090740c616021f3dab4ea8f7b46b0a0c067 [diff]
Add fetcher interface and implement it with direct fetcher

The new IpProtectionProxyConfigFetcher interface has a single function
to get the proxy config. That does not accept an OAuth token since such
a thing is particular to the direct method, only available on the
browser, and not always used. This interface will be used in the network
service as well, so such a parameter doesn't make sense.

Instead, direct fetcher authentication (either via API key or OAuth
token) is handled with a callback.

With this change, the OAuth token and API key logic moves to the
`CoreHost`, so the relevant tests do as well. In the process, those
tests are updated to use a URL loader factory rather than a mock
retriever, which allows the retriever to be made private.

Bug: 352005196
Change-Id: I0ca64cbbb32cfa8710fdb17c419a38b7ed119d6e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5840463
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Abhijith Nair <abhijithnair@chromium.org>
Commit-Queue: Dustin Mitchell <djmitche@chromium.org>
Reviewed-by: Richard (Torne) Coles <torne@chromium.org>
Reviewed-by: Andrew Williams <awillia@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1354533}
15 files changed
tree: a0578a12758ccab6e6ef4d07eb6ed2fade9c3b8f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitallowed
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. CPPLINT.cfg
  76. CRYPTO_OWNERS
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.