[Clipboard] Add CFSTR_INETURL format to clipboard on windows when
image has non-empty source url.

The CL addresses the bug where browser does not add CFSTR_INETURL
or UniformResourceLocatorW format when image has empty source url
or empty alternate text (title). When right click is performed on
an image and copy image is triggered via context menu, the
|WriteImageToClipboard| in system clipboard is executed. This
calls |WriteImageWithTag| which in turn calls |WriteBookmark| and
redirects to the method in browser clipboard via mojom IPC. Here,
based on the condition that either source url or title is empty,
it drops further call and makes early return.

But, if the source url is non-empty, it should be added irrespective
of empty alternate text. The bug is fixed by removing the check on
alt text and only the url check is done for adding or not adding the
required format. This behavior is specific to Windows/Android, where
the format added is defined for Windows. In Android, the format is
already being added (Android specific) with or without the change.
MAC OS doesn't have this format and also for linux we never call
|ReadBookmark| and it is in NOT IMPLEMENTED state.

Bug: 40686999
Change-Id: Iaf9cbbf724fc9d8608537ee0c457b814f0225389
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5775430
Reviewed-by: Dana Fried <dfried@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Pranav Modi <pranavmodi@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1364042}
7 files changed
tree: 97101bc66a082c7be93f7ed22599388f944ada2c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .git-blame-ignore-revs
  54. .gitallowed
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. CPPLINT.cfg
  69. CRYPTO_OWNERS
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.