Google Git
Sign in
chromium / chromium / src / fda0004818352c1a1205a14d4c4be72fe9600bde
commitfda0004818352c1a1205a14d4c4be72fe9600bde[log] [tgz]
authorVictor Hugo Vianna Silva <victorvianna@google.com>Fri Sep 20 17:17:52 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Sep 20 17:17:52 2024
treedb70ab0a1ce8b57b264bc8309a34e474299dc9ff
parent9278072ba96083d235df33c83c46d7eb2ca458a4 [diff]
[android] Defer StoragePartition::SetProtoDatabaseProvider()

See https://crbug.com/368011043 for more details. Logging locally
shows that this is the call that ends up prematurely creating the
IdentityManager. Move it from here [1] to a few lines below in [2]
(well, the call now lives in OnLocaleReady(), which is called by
OnPrefsLoaded(); async_prefs is always false on Android AFAICT).

This makes sure the migration occurs before IdentityManager
instantiation. It probably does not fix the problem for all keyed
services.

[1] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/profiles/profile_impl.cc;l=493;drc=1e68ae23ca876e9f1b9ab3e71bcce0472ca1830c
[2] https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/profiles/profile_impl.cc;l=529;drc=1e68ae23ca876e9f1b9ab3e71bcce0472ca1830c

Fixed: 368011043,367970487
Change-Id: Ifabd8632c274f1e1eee78f9a45f42ddc2331cfb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5872575
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1358241}
1 file changed
tree: db70ab0a1ce8b57b264bc8309a34e474299dc9ff
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. clank
  51. internal
  52. ios_internal
  53. native_client
  54. signing_keys
  55. v8
  56. .clang-format
  57. .clang-tidy
  58. .clangd
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitallowed
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. CPPLINT.cfg
  76. CRYPTO_OWNERS
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.