Google Git
Sign in
chromium / chromium / src / fdc113ae10a1f2fb3e67015b2fd1d8e7cc0d0acc
commitfdc113ae10a1f2fb3e67015b2fd1d8e7cc0d0acc[log] [tgz]
authorJohn Rummell <jrummell@chromium.org>Fri Nov 01 01:28:09 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Nov 01 01:28:09 2024
tree650fe2677f305308a8bdc60736bafd19d161936c
parentb6725de24416503011f8e560c98f91aa21160cbb [diff]
Log MediaCodec errors to UMA

Currently the errors are returned as a TypedStatus so they are visible
to users via chrome://media-internals. However, the UMA used for
PipelineStatus just logs "Error", so the detailed reason is lost. Adding
a new UMA to record the error returned by MediaCodec. Like the
PipelineStatus UMA, there is one for each different video codec, and
each are split on whether they use software or hardware secure codecs.

Tested by modifying the code to simulate an error and seeing it reported
via chrome://histograms.

- Histogram: Media.MediaCodecError.H264.HardwareSecure recorded 1 samples, mean = 11.0 (flags = 0x41) [#]
0   ...
11  -O                                             (1 = 100.0%) {0.0%}
12  ...

Bug: 376720476
Test: see above

Change-Id: I59cd978832f67af813fe95ed22645f189c5f5b39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5983407
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Reviewed-by: Evan Liu <evliu@google.com>
Cr-Commit-Position: refs/heads/main@{#1376710}
5 files changed
tree: 650fe2677f305308a8bdc60736bafd19d161936c
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.