| commit | fe855f8d21963c3f04a239e23bd2bc23db9bbdf8 | [log] [tgz] |
|---|---|---|
| author | Nihar Majmudar <niharm@google.com> | Tue Apr 30 21:34:09 2024 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Apr 30 21:34:09 2024 |
| tree | cb5a991ce580e326ffe6b3532fe3f187d7bc4cbb | |
| parent | 67aef2bf4b2822e9a0219be32562101e28a0068c [diff] |
[search bubble] Set bubble_view_ to nullptr on close. In certain cases, the search bubble would not open when Show() was called after Close() because the bubble_view_ still existed. This fixes that problem by explicitly setting bubble_view_ to nullptr every time the bubble is closed in the controller. Bug: 328295135 Change-Id: Ib4bf08e971dac8d8ca5384d34d4c6db850afa54c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5502790 Reviewed-by: Juan Mojica <juanmojica@google.com> Commit-Queue: Nihar Majmudar <niharm@google.com> Cr-Commit-Position: refs/heads/main@{#1294602}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.