commit | fe8c4db4003022f5cb12506a15cc78ea6633bbdf | [log] [tgz] |
---|---|---|
author | Stefan Zager <szager@chromium.org> | Thu Feb 01 16:33:24 2018 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Feb 01 16:33:24 2018 |
tree | 886889374483955b54437f4b3ce2fe1ff8e7f9ea | |
parent | ecc43a2f3233d5c3189f6fc79c13aa5f714c9e4c [diff] |
[RootLayerScrolls] Flip RuntimeEnabledFeatures flag to experimental *** PLEASE DO NOT REVERT *** This CL is the culmination of literally years of work. If you believe it is breaking something, please contact szager@chromium.org or skobes@chromium.org before reverting. With this change, all blink layout tests will run with root layer scrolling enabled. The main components of this patch: 1) Set the runtime_enabled_features.json5 entry for "RootLayerScrolling" to "experimental". 2) Remove virtual/rootlayerscrolls prefix from entries in LayoutTests/TestExpectations and FlagExpectations/*, and resolve redundancies with existing expectations lines. 3) Copy the current contents of LayoutTests/TextExpectations to LayoutTests/FlagExpectations/no-root-layer-scrolls 4) Append the contents of FlagExpectations/root-layer-scrolls to TestExpectations 5) Remove the "rootlayerscrolls" entries from VirtualTestSuites, and remove the "--root-layer-scrolls" flag from all remaining entries in that file. 6) Delete the directory LayoutTests/virtual/rootlayerscrolls, and all of its contents. 7) Move/copy test expectations files in LayoutTests/flag-specific/root-layer-scrolls and in the canonical (i.e., not flag-specific) LayoutTests/ locations as follows: - for each layout test that has at least one expectation file in flag-specific/root-layer-scrolls/: - if the test has any .png files in flag-specific/root-layer-scrolls/: - move all .png files in the canonical location to flag-specific/no-root-layer-scrolls - move all .png files in flag-specific/root-layer-scrolls/ to the canonical location. - if the test has any .txt files in flag-specific/root-layer-scrolls/: - move all .txt files in the canonical location to flag-specific/no-root-layer-scrolls - move all .txt files in flag-specific/root-layer-scrolls/ to the canonical location. BUG=417782 R=skobes@chromium.org,bokan@chromium.org,chrishtr@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7a13ad251efc573acc5b737bd9ca29adf21a5c87 Reviewed-on: https://chromium-review.googlesource.com/893624 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by: Steve Kobes <skobes@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#533694}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .