commit | fec9b6f1b3e8692021dd0c90748946ac33a1c7d8 | [log] [tgz] |
---|---|---|
author | Jordan Demeulenaere <jdemeulenaere@google.com> | Thu May 23 09:02:44 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu May 23 09:02:44 2019 |
tree | 44319bddc75560cb2c2355cbd996d6123bdf43ae | |
parent | 97f6153d116a2d5ca930750df7e274e16683684b [diff] |
[Autofill Assistant] Don't clip sheet content if it is not scrollable. This CL disables the clipping of the bottom sheet content if it is not scrollable. This allows to correctly display the details shadow if it is the only visible element in the scrollable area. We still need to enable the clipping of the content if it is scrollable, otherwise scrolled content will overlap the carousel and header (given how the ScrollView works internally). This is fine as the details are usually shown at the top of the scrollable area, so clipping it when it happens shouldn't have an impact on the details shadow. Given that the actions carousel was relying on the clipChildren flag to be disabled, the spacing before and above the carousel has been moved into the carousel item decorations. * Before: https://screenshot.googleplex.com/p6DUiOBnyDp.png * After: https://screenshot.googleplex.com/AAKU42uvhgv.png Screenshots: Change-Id: I900f47ab41a36cb3f2140d1387671e392d694d42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624194 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by: Clemens Arbesser <arbesser@google.com> Reviewed-by: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#662543}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .