Use reply_callback when using base::GetDelete*Callback() in /chrome/browser/ash/system_logs Currently there's a use pattern as follows: ``` PostTaskAndReply(base::GetDeleteFileCallback(path), callback) ``` This means that when base::GetDeleteFileCallback() returns, the callback will be called. However, since base::GetDeleteFileCallback() has retry logic, even after base::GetDeleteFileCallback() returned, there might still be tasks trying to delete the path. This is not safe if the caller tries to access the path in the reply callback. Because of this, a reply callback has been added: ``` base::GetDeleteFileCallback(path, reply_callback) ``` The `reply_callback` is guaranteed be called after the whole retry logic has been finished. This CL replaces the pattern ``` PostTaskAndReply(base::GetDeleteFileCallback(path), callback) ``` with ``` PostTask(base::GetDeleteFileCallback(path, callback)), ``` assuming that's the original intention of the code. This CL was uploaded by git cl split. R=xiangdongkong@google.com Bug: 1321695 Change-Id: I02c653d03e052a6ee093bd7d1a2c3eaf1b6e7355 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3655121 Auto-Submit: Xiaohan Wang <xhwang@chromium.org> Reviewed-by: Xiangdong Kong <xiangdongkong@google.com> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1005635}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.