| commit | feec9817b45c4adc88e26ea9fc8323c4078fd5d6 | [log] [tgz] |
|---|---|---|
| author | Christoph Schwering <schwering@google.com> | Fri Jun 20 11:05:52 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jun 20 11:05:52 2025 |
| tree | 57bd2e8ec8318af5fab023040a9eb8d279c820da | |
| parent | 6eec8ab6c0f500a3931934ebe5659720e0364edf [diff] |
Revert "[Autofill] Refactor BrowserAutofillManager methods to accept ids" This reverts commit 7156660c0068122272799dcb9433bcf086061fe9. Reason for revert: The pointer `autofill_field` BrowserAutofillManager::BuildSuggestionsContext() may be null if it's not in the cache. Original change's description: > [Autofill] Refactor BrowserAutofillManager methods to accept ids > > This change refactors `BrowserAutofillManager` methods. Instead of > passing full `Field` or `Form` objects, these methods now accept ids > when only the identifier is needed, leading to a more streamlined > approach. Additionally, the redundant `FormFieldData` argument has been > removed from `BuildSuggestionsContext`. > > Bug: 09962888 > Change-Id: I46b9faa510d8f414b6c678fe1fd55fd34951c7fb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6641907 > Commit-Queue: Piotr Kotynia <piotrkotynia@google.com> > Reviewed-by: Christoph Schwering <schwering@google.com> > Cr-Commit-Position: refs/heads/main@{#1474042} Bug: 425798641, 425118330, 409962888 Change-Id: Id2de3e2a2ed897df4c8bfcd6713db2ed1cb4ff4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6653098 Auto-Submit: Christoph Schwering <schwering@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Jihad Hanna <jihadghanna@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#1476427}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.