Nicer uniform traces for audio latency and glitches. Convert delay and glitch info in traces to a unified naming scheme and use the same precision (float ms). The main reason: Perfetto UI allows to visualize an specific argument value throughout the whole trace (in all calls on all threads). (Like this https://screenshot.googleplex.com/3o2CwbwhhwUy27f). So if an argument has the same name throughout the whole stack, we can visualize it everywhere with on click and see, for example, where the audio latency increases. Example trace: https://ui.perfetto.dev/#!/?s=ab0bf4d3ee9333499cd75d67c9ad89459da31322a7cba339af1a5ac3b7307a87 Proposed conventions: * Playout stack: ** "playout_delay (ms)" ** "playout_timestamp (ms)" * Capture stack: ** "capture_delay (ms)" ** "capture_time (ms)" * Bridges between push and pull model, where it's unclear, for example, if the audio is pushed to be played or to be captured, and what is its source: ** "layover_delay (ms)" ** "reference_time (ms)" * Additional info, where appropriate: ** "delay (frames)" ** "fifo delay (ms)" Change-Id: I29df2427c222a0d1b0bf7996ff34e1f30c7cbb0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5594219 Reviewed-by: Fredrik Hernqvist <fhernqvist@google.com> Reviewed-by: Michael Wilson <mjwilson@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/main@{#1335578}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.