Google Git
Sign in
chromium / chromium / src / ff568f338665357bf0cd60b437712ca432da48ed
commitff568f338665357bf0cd60b437712ca432da48ed[log] [tgz]
authorDavid Roger <droger@chromium.org>Tue May 10 08:51:27 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue May 10 08:51:27 2022
tree63f95db707e093bfc0ea56ab18e90c8578f6ecf3
parent0e84fcd1e0eebe9803eeed405f6438be4ea5d0f2 [diff]
[Lacros] Prepare for fixing Sync error from profile menu

ShowReauthForPrimaryAccountWithAuthError() previously tried to enable
sync again after fixing the account error.

This CL changes the logic so that only the error is fixed, but sync is
not re-enabled while already running.

This is causing a small behavior change on desktop as well: a regular
gaia signin tab is shown, rather that the custom Chrome sync tab.

This change is in preparation for starting the sync flow based on the
`enable_sync` value.

Bug: None
Change-Id: I45eab94929a237f64daf867a6ed8f4812fe5a815
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3629359
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1001410}
4 files changed
tree: 63f95db707e093bfc0ea56ab18e90c8578f6ecf3
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.