commit | ff69943b5e8b06053cc0715efdc749bead4a3b02 | [log] [tgz] |
---|---|---|
author | Aishwarya Rajesh <aishwaryarj@google.com> | Mon Sep 25 23:20:05 2023 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Sep 25 23:20:05 2023 |
tree | e6df24eb8df61befcae32f5dc289bef252f64daa | |
parent | da0106499dbde98e092e37b91abe15be035817ee [diff] |
[APS] Post clearance of hover state on tab strip down event Currently, TabStripEventHandler#onDown() attempts to clear any persisting tab hover state when a down event is received on the strip; a down event is always received before a subsequent click/drag/long press/fling etc. However, during a tab close button click, the clearance does not take effect possibly due to tab closure animations. This CL introduces a PostTask to reasonably delay hover state clearance in onDown() as a best effort for the clearance to take effect after any animations triggered due to the down event have ended. This would mean that showing the hover card for a tab that is possibly moved to the point of tab closure, or for a tab that is selected, as a result of a click (that follows a down event) on the tab strip, will be deferred to until after a subsequent hover move event is detected from the point of the down event. Bug: 1483487, 1451925 Change-Id: I426b6178a5052a97a738fe627f35bd6dcb2106d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4878237 Reviewed-by: Neil Coronado <nemco@google.com> Commit-Queue: Aishwarya Rajesh <aishwaryarj@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Sirisha Kavuluru <skavuluru@google.com> Cr-Commit-Position: refs/heads/main@{#1201205}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.