[APS] Post clearance of hover state on tab strip down event

Currently, TabStripEventHandler#onDown() attempts to clear any
persisting tab hover state when a down event is received on the strip; a
down event is always received before a subsequent click/drag/long
press/fling etc. However, during a tab close button click, the clearance
does not take effect possibly due to tab closure animations.

This CL introduces a PostTask to reasonably delay hover state clearance
in onDown() as a best effort for the clearance to take effect after any
animations triggered due to the down event have ended. This would mean
that showing the hover card for a tab that is possibly moved to the
point of tab closure, or for a tab that is selected, as a result of a
click (that follows a down event) on the tab strip, will be deferred to
until after a subsequent hover move event is detected from the point of
the down event.

Bug: 1483487, 1451925
Change-Id: I426b6178a5052a97a738fe627f35bd6dcb2106d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4878237
Reviewed-by: Neil Coronado <nemco@google.com>
Commit-Queue: Aishwarya Rajesh <aishwaryarj@google.com>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Reviewed-by: Sirisha Kavuluru <skavuluru@google.com>
Cr-Commit-Position: refs/heads/main@{#1201205}
2 files changed
tree: e6df24eb8df61befcae32f5dc289bef252f64daa
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.