| commit | ffa032aa746954106635699e59f2cf3b356a49fe | [log] [tgz] |
|---|---|---|
| author | Evelynn Kaplan <evelynn.kaplan@microsoft.com> | Fri Jan 10 17:58:53 2025 |
| committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 10 17:58:53 2025 |
| tree | 948a84eef0e1b9d6b167c08cbe4a615838f55d8b | |
| parent | f841e81a1b7d6d9765e51e658f6aae3a15644d84 [diff] |
[views-ax] Remove workaround for Views without roles in ViewAX::SetName This CL removes a code workaround in `ViewAccessibility::SetName` that was put in place to avoid a DCHECK in cases where Views did not set their accessible role before making a call to set their accessible name. `ViewAccessibility::SetName` makes a call to `AXNodeData::SetName`, which expects a valid role. A series of ViewsAX CLs has been landed to ensure that all Views set their accessible roles at time of construction, so this code mitigation can be removed. This CL is part of the ViewsAX project: https://docs.google.com/document/d/1Ku7HOyDsiZem1yaV6ccZ-tz3lO2XR2NEcm8HjR6d-VY/edit#heading=h.ke1u3utej413 Bug: 325137417 Change-Id: I2edd8150b6dbb7906113e63aa8ca0a38a28a414c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164848 Reviewed-by: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1404871}
ChromiumChromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.