commit ffc78cf90a0c0e0b041151cc440838d5c92b4678
author Lucas Radaelli <lucasradaelli@google.com> Wed Sep 18 19:22:15 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Wed Sep 18 19:22:15 2024
tree b58168daf06dd6eb9c1ea8f9421a72bb08eded40
parent d0158f39d2f83762e9bfea501568378ab9fa4f4f

[a11y] Repairs aria owns relations on children changed

This change fixes a bug where an element, when
receiving focus, would lose its aria owned nodes,
if it also has a pseudo element text.

Long explanation:
When the button receives focus, before sending the
focus event, blink engine recomputes the style of
the pseudo element text, which causes its parent
(the button), to delete its subtree. Thus:
- The button's subtree is removed; (layout not
  clean)
- The aria-owned element is cleared, and the
  relations are also cleared in the relations
  cache; (layout not clean)
- A children changed tree update is scheduled, to
  be executed when the lifecycle advances to
  process deferred events; (layout not clean)
  Layout clean operations:
- The button updates its cached values, as a
  result of processing the deferred update above;
- The button must update its children, so they get
  cleared;
- The button re-adds its children, and the
  aria-owned element is not added because it was
  not added to the cache.

This change forces a recomputation of aria owns
cache relations after a children changed tree
update during clean layout, to make sure that the
button will re-add children that are aria owned.

Test: DumpAccessibilityTreeTest.AccessibilityFocusedButtonWithAriaOwns
Bug: 361801686
Change-Id: I9d34c501b15cae7a96287b58f93ed0685d47a09b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5857657
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Aaron Leventhal <aleventhal@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1357258}