Revert "media/gpu/v4l2vd: Reallocate OUTPUT buffers if needed on resolution change" This reverts commit ad7718f78afcc9e022ff2e106b830c77dd3c7485. Reason for revert: This breaks stateful V4L2 decoders (such as on trodgor and strongbad). Since this CL fixes a corner case with the rkvdec kernel driver that is already worked around, it is safe to revert. Original change's description: > media/gpu/v4l2vd: Reallocate OUTPUT buffers if needed on resolution change > > Some V4L2 stateless decoder kernel drivers override the buffer size we > request. This likely results in a tiny buffer size due to the initial > minimal frame size. Attempting to use the same buffers after a dynamic > resolution change would fail if the next coded frame does not fit in > the old buffer. > > To fix this, after the new resolution is applied, check if the returned > buffer size in `sizeimage` is larger than the buffers we currently hold. > If so, return the old buffers and request new ones. > > BUG=b:202919860 > TEST=Run vda_tests with test-25fps.h264 on Kevin -kernelnext without > crrev.com/c/3211697 > (also need to manually swap /dev/media-dec[01] for now) > > R=​frkoenig, mcasas > > Change-Id: Ic68e5c33f1d0f60a61128e2bffa0d0c6f7f701d8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3220949 > Auto-Submit: Chen-Yu Tsai <wenst@chromium.org> > Commit-Queue: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Cr-Commit-Position: refs/heads/main@{#934217} Bug: b:202919860 Bug: b:204376269 Change-Id: I71e98b7a7ebde9b6a6ab8664062c785eef408f66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3261886 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by: Miguel Casas <mcasas@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/main@{#938842}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.