Google Git
Sign in
chromium / chromium / src / master
commit62ca219820c1ae48669355f0153926a9e48bc647[log] [tgz]
authorDavid Black <dmblack@google.com>Tue Sep 22 21:54:16 2020
committerCommit Bot <commit-bot@chromium.org>Tue Sep 22 21:54:16 2020
tree21166fae223f6d19fbbc71aded45647d85edc39a
parent5c868eac5fa085ec37430bfee54490f1aa45633f [diff]
Don't attempt to update holding space item chip view pin if deleted.

Unpinning an item from its view may result in that view being deleted.
If the view is deleted, we shouldn't attempt to update its pin.

Bug: 1130086
Change-Id: Ib5c8dbe086b4446161569924b3c81a9bd37d272c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422247
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809526}
2 files changed
tree: 21166fae223f6d19fbbc71aded45647d85edc39a
  1. .clang-format
  2. .clang-tidy
  3. .eslintrc.js
  4. .git-blame-ignore-revs
  5. .gitattributes
  6. .gitignore
  7. .gn
  8. .vpython
  9. .vpython3
  10. .yapfignore
  11. AUTHORS
  12. BUILD.gn
  13. CODE_OF_CONDUCT.md
  14. DEPS
  15. DIR_METADATA
  16. ENG_REVIEW_OWNERS
  17. LICENSE
  18. LICENSE.chromium_os
  19. OWNERS
  20. PRESUBMIT.py
  21. PRESUBMIT_test.py
  22. PRESUBMIT_test_mocks.py
  23. README.md
  24. WATCHLISTS
  25. android_webview/
  26. apps/
  27. ash/
  28. base/
  29. build/
  30. build_overrides/
  31. buildtools/
  32. cc/
  33. chrome/
  34. chromecast/
  35. chromeos/
  36. cloud_print/
  37. codereview.settings
  38. components/
  39. content/
  40. courgette/
  41. crypto/
  42. dbus/
  43. device/
  44. docs/
  45. extensions/
  46. fuchsia/
  47. gin/
  48. google_apis/
  49. google_update/
  50. gpu/
  51. headless/
  52. infra/
  53. ios/
  54. ipc/
  55. jingle/
  56. media/
  57. mojo/
  58. native_client_sdk/
  59. net/
  60. pdf/
  61. ppapi/
  62. printing/
  63. remoting/
  64. rlz/
  65. sandbox/
  66. services/
  67. skia/
  68. sql/
  69. storage/
  70. styleguide/
  71. testing/
  72. third_party/
  73. tools/
  74. ui/
  75. url/
  76. weblayer/
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.