Google Git
Sign in
chromium / chromium / src / refs/heads/main
commitff90533c0941ae48cb90a308d987ddd329c29594[log] [tgz]
authorJoe Mason <joenotcharles@google.com>Fri Jan 23 03:08:56 2026
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Jan 23 03:08:56 2026
tree5365e27d0e1b0174d05abfd3ca7b61915bfbbd2c
parent2d056feee14fd55c2be5182a7c330e1c515bcc5d [diff]
Annotate locks in PipelineImpl::RendererWrapper

The "WebMediaPlayer_MainThread" MemoryDumpProvider can take a long time
to run. I suspect the cause is contention on the lock for
RendererWrapper::SharedState, which is taken by GetPipelineStatistics()
during a memory dump.

The lock semantics are complicated. To help in the investigation, this
adds SEQUENCE_CHECKER and EXCLUDED_LOCKS_REQUIRED annotations to make
sure the locks are being accessed as described in the SharedState
documentation comment. SharedState is now owned by a wrapper class,
SharedStateAccessor, that exposes const refs to SharedState on all
threads, but only exposes a mutable ref to the media thread.

This uncovered two existing issues:

 * `did_loading_progress` is written from both threads, contradicting the documented semantics. To support this, it's moved to SharedStateAccessor with its own EXCLUSIVE_LOCKS_REQUIRED annotation.
 * ReportMetadata() writes `suspend_timestamp` without holding the lock. Added the missing lock.

Also removed a lock in RenderWrapper::Resume that was shown to be
unneeded.

Bug: 41419817,450929521
Change-Id: Iefd4c47b8080bf53e808769747601136fab755be
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7506130
Commit-Queue: Joe Mason <joenotcharles@google.com>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1573465}
1 file changed
tree: 5365e27d0e1b0174d05abfd3ca7b61915bfbbd2c
  1. .claude/
  2. .gemini/
  3. .github/
  4. agents/
  5. android_webview/
  6. apps/
  7. ash/
  8. base/
  9. build/
  10. build_overrides/
  11. buildtools/
  12. cc/
  13. chrome/
  14. chromecast/
  15. chromeos/
  16. codelabs/
  17. components/
  18. content/
  19. crypto/
  20. dbus/
  21. device/
  22. docs/
  23. extensions/
  24. fuchsia_web/
  25. gin/
  26. google_apis/
  27. gpu/
  28. headless/
  29. infra/
  30. ios/
  31. ipc/
  32. media/
  33. mojo/
  34. net/
  35. pdf/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. clusterfuzz-data
  53. internal
  54. ios_internal
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .cursorignore
  61. .geminiignore
  62. .git-blame-ignore-revs
  63. .gitallowed
  64. .gitattributes
  65. .gitignore
  66. .gitmodules
  67. .gn
  68. .mailmap
  69. .rustfmt.toml
  70. .vpython3
  71. .yapfignore
  72. ATL_OWNERS
  73. AUTHORS
  74. BUILD.gn
  75. CODE_OF_CONDUCT.md
  76. codereview.settings
  77. CPPLINT.cfg
  78. CRYPTO_OWNERS
  79. DEPS
  80. DIR_METADATA
  81. LICENSE
  82. LICENSE.chromium_os
  83. OWNERS
  84. package.json
  85. PRESUBMIT.py
  86. PRESUBMIT_test.py
  87. PRESUBMIT_test_mocks.py
  88. README.md
  89. SECURITY_OWNERS
  90. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.