Ensure RenderFrameHostImpl's RenderFrameSetupPtr doesn't die too early
RenderFrameHostImpl is creating a RenderFrameSetupPtr, binding it via
ConnectToRemoteService(), and then using it to bootstrap the per-frame
Mojo connection. However, it holds this instance in a local variable,
meaning that the pipe is closed when the local variable goes out of
scope. The closing of the pipe races with the processing of the message
write that is the result of calling
RenderFrameSetupPtr->GetServiceProviderForFrame(), as that processing occurs
on a different thread. The net outcome is that the per-frame Mojo
connection will flakily fail to be set up.
To eliminate this race, this CL changes the RenderFrameSetupPtr instance
that the RFHI holds from a local variable to a member variable.
BUG=424069
TEST=Visit about://omnibox in multiple tabs. In each tab, check that submitting
text causes output to appear.
Review URL: https://codereview.chromium.org/667683002
Cr-Commit-Position: refs/heads/master@{#300864}
2 files changed
