styleguide/web/web.md - chromium/src - Git at Google

 # Chromium Web Development Style Guide

 [TOC]

 ## Where does this style guide apply?

 This style guide targets Chromium frontend features implemented with TypeScript,
 CSS, and HTML. Developers of these features should adhere to the following
 rules where possible, just like those using C++ conform to the [Chromium C++
 styleguide](../c++/c++.md).

 This guide follows and builds on:

 * [Google HTML/CSS Style Guide](https://google.github.io/styleguide/htmlcssguide.html)
 * [Google TypeScript Style Guide](https://google.github.io/styleguide/tsguide.html)
 * [Google JavaScript Style Guide](https://google.github.io/styleguide/jsguide.html)
 * [Google Polymer Style Guide](http://go/polymer-style)

 *** aside
 Note: Concerns for browser compatibility are usually not relevant for
 Chromium-only code.
 ***

 ## Separation of presentation and content

 When designing a feature with web technologies, separate the:

 * **content** you are presenting to the user (**HTML**)
 * **styling** of the data (**CSS**)
 * **logic** that controls the dynamic behavior of the content and presentation
   (**TS**)

 This highlights the concern of each part of the code and promotes looser
 coupling (which makes refactor easier down the road).

 Another way to envision this principle is using the MVC pattern:

 | MVC Component | Web Component |
 |:-------------:|:-------------:|
 | Model         | HTML          |
 | View          | CSS           |
 | Controller    | TS            |

 It's also often appropriate to separate each implementation into separate files.

 DO:
 ```html
 <!-- missile-button.html -->
 <link rel="stylesheet" href="warnings.css">
 <b class="warning">LAUNCH BUTTON WARNING</b>
 <script src="missile-button.js">
 ```
 ```css
 /* warnings.css */
 .warning {
   color: red;
 }
 ```
 ```js
 // missile-button.js
 document.querySelector('b').onclick = fireZeeMissiles;
 ```

 DON'T:
 ```html
 <!-- missile-button.html -->
 <b style="color: red;" onclick="fireZeeMissiles()">LAUNCH BUTTON WARNING</b>
 ```

 *** aside
 Note: For various technical and historical reasons, code using the Polymer
 library may use `on-event`-style event listener wiring and `<style>` tags that
 live inside of .html files.
 ***

 ## HTML

 See the [Google HTML/CSS Style
 guide](https://google.github.io/styleguide/htmlcssguide.html).

 ### Head

 ```html
 <!doctype html>
 <html dir="$i18n{direction}">
 <head>
   <meta charset="utf-8">
   <title>$i18n{myFeatureTitle}</title>
   <link rel="icon" href="feature.png">
   <link rel="stylesheet" href="feature.css">
   <script src="feature.js"></script>
 </head>
 …
 </html>
 ```

 * Specify `<!doctype html>`.

 * Set the `dir` attribute of the html element to the localized ‘textdirection’
   value.  This flips the page visually for RTL languages and allows
   `html[dir=rtl]` selectors to work.

 * Specify the charset, UTF-8.

 * Link in image, icon and stylesheet resources.
     * Do not style elements with `style="..."` attributes.

 * Include the appropriate JS scripts.
     * Do not add JS to element event handlers.

 *** aside
 Note: Polymer event handlers like `on-click` are allowed and often reduce the
 amount of addressing (adding an ID just to wire up event handling).
 ***

 ### Body

 ```html
 <h3>$i18n{autofillAddresses}</h3>
 <div class="settings-list">
   <list id="address-list"></list>
   <div>
     <button id="autofill-add-address">$i18n{autofillAddAddress}</button>
   </div>
 </div>
 <if expr="chromeos">
   <a href="https://www.google.com/support/chromeos/bin/answer.py?answer=142893"
       target="_blank">$i18n{learnMore}</a>
 </if>
 ```

 * Element IDs use `dash-form`
     * Exception: `camelCase` is allowed in Polymer and Lit code for easier
       `this.$.idName` access.

 * Localize all strings using $i18n{}

 * Use camelCase for $i18n{} keys names.

 * Add 2 space indentation in each new block.

 * Adhere to the 80-column limit.
     * Indent 4 spaces when wrapping a previous line.

 * Use double-quotes instead of single-quotes for all attributes.

 * Don't close single tags
     * DO: `<input type="radio">`
     * DON'T: `<input type="radio" />`

 *** aside
 Note: All `<custom-elements>` and some HTML elements like `<iframe>` require
 closing.
 ***

 * Use the `button` element instead of `<input type="button">`.

 * Do not use `<br>`; place blocking elements (`<div>`) as appropriate.

 * Do not use spacing-only divs; set the margins on the surrounding elements.

 * Only use `<table>` elements when displaying tabular data.

 * Do not use the `for` attribute of `<label>`
     * If you're labelling a checkbox, put the `<input>` inside the `<label>`
     * If you're labelling purely for accessibility, e.g. a `<select>`, use
       `aria-labelledby`

 ## CSS

 See the [Google HTML/CSS style
 guide](https://google.github.io/styleguide/htmlcssguide.html) (and again, browser
 compatibility issues are less relevant for Chrome-only code).

 ```css
 .raw-button,
 .raw-button:hover,
 .raw-button:active {
   --sky-color: blue;
   -webkit-margin-collapse: discard;
   background-color: rgb(253, 123, 42);
   background-repeat: no-repeat;
   border: none;
   min-width: 0;
   padding: 1px 6px;
 }
 ```

 * Specify one selector per line.
      * Exception: One rule / one line frames in a `@keyframe` (see below).

 * Opening brace on the same line as the last (or only) selector.

 * Two-space indentation for each declaration, one declaration per line,
   terminated by a semicolon.

 * Use shorthand notation when possible.

 * Alphabetize properties.
     * `-webkit` properties should be listed at the top, sorted alphabetically.
     * `--variables` should be alphabetically declared when possible.

 * Insert a space after the colon separating property and value.

 * Do not create a class for only one element; use the element ID instead.

 * When specifying length values, do not specify units for a zero value, e.g.,
   `left: 0px;` becomes `left: 0;`
     * Exception: 0% values in lists of percentages like `hsl(5, 0%, 90%)` or
       within @keyframe directives, e.g:
 ```css
 @keyframe animation-name {
   0% { /* beginning of animation */ }
   100% { /* end of animation */ }
 }
 ```

 * Use single quotes instead of double quotes for all strings.

 * Don't use quotes around `url()`s unless needed (i.e. a `data:` URI).

 * Class names use `dash-form`.

 * If time lengths are less than 1 second, use millisecond granularity.
     * DO: `transition: height 200ms;`
     * DON'T: `transition: height 0.2s;`

 * Use two colons when addressing a pseudo-element (i.e. `::after`, `::before`,
   `::-webkit-scrollbar`).

 * Use scalable `font-size` units like `%` or `em` to respect users' default font
   size

 * Don't use CSS Mixins (`--mixin: {}` or `@apply --mixin;`).
     * CSS Mixins are defunct after Oct 2022, see
       [crrev.com/c/3953559](https://crrev.com/c/3953559)
     * All CSS Mixins usages have been removed from Chromium, see
       [crbug.com/973674](https://crbug.com/973674) and
       [crbug.com/1320797](https://crbug.com/1320797)
     * Mixins were [dropped from CSS](https://www.xanthir.com/b4o00) in favor of
       [CSS Shadow Parts](https://drafts.csswg.org/css-shadow-parts/).
     * Instead, replace CSS mixin usage with one of these natively supported
       alternatives:
         * CSS Shadow Parts or CSS variables for styling of DOM nodes residing in
           the Shadow DOM of a child node.
         * Plain CSS classes, for grouping a set of styles together for easy
           reuse.

 ### Color

 * When possible, use named colors (i.e. `white`, `black`) to enhance
   readability.

 * Prefer `rgb()` or `rgba()` with decimal values instead of hex notation
   (`#rrggbb`).
     * Exception: shades of gray (i.e. `#333`)

 * If the hex value is `#rrggbb`, use the shorthand notation `#rgb`.

 ### URLs

 * Don't embed data URIs in source files. Instead, use a relative path to an icon
   in your UI (and include this icon in the generated grd file), or use an
   absolute URL for an icon from the shared resources at ui/webui/resources:

 ```css
 background-image: url(chrome://resources/images/path/to/image.svg);
 ```

 ### RTL

 ```css
 .suboption {
   margin-inline-start: 16px;
 }

 #save-button {
   color: #fff;
   left: 10px;
 }

 html[dir='rtl'] #save-button {
   right: 10px;
 }
 ```

 Use RTL-friendly versions of things like `margin` or `padding` where possible:

 * `margin-left` -> `margin-inline-start`
 * `padding-right` -> `padding-inline-end`
 * `text-align: left` -> `text-align: start`
 * `text-align: right` -> `text-align: end`
 * set both `left` for `[dir='ltr']` and `right` for `[dir='rtl']`

 For properties that don't have an RTL-friendly alternatives, use
 `html[dir='rtl']` as a prefix in your selectors.

 ## TypeScript

 New WebUI code should be written in TypeScript. Some legacy code is still using
 JavaScript, but it is expected that all code should migrate to TS eventually.

 ### Style

 The Chromium styleguide is combination of 3 components:

   1. The [Google TypeScript Style Guide](
      https://google.github.io/styleguide/tsguide.html) which is used as the
      starting point.
   2. [ECMAScript Features in Chromium](es.md), which specifies which ES features
      should or shouldn't be used in Chromium.
   3. Additional guidelines applied on top of #1, which are listed below.


 Additional guidelines:

 * Use `$('element-id')` instead of `document.getElementById`. This function can
   be imported from util.m.js.

 * Use single-quotes instead of double-quotes for all strings. `clang-format` now
   handles this automatically.

 * Prefer `event.preventDefault()` to `return false` from event handlers.

 * Prefer `this.addEventListener('foo-changed', this.onFooChanged.bind(this));`
   instead of always using an arrow function wrapper, when it makes the code less
   verbose without compromising type safety (for example in TypeScript files).

 * When using `?.` be aware that information about the original location of the
   null/undefined value can be lost. You should avoid cases like this and instead
   prefer explicit error checking:
 ```js
 const enterKey = keyboards.getCurrentKeyboard()?.getKeys()?.getEnterKey();
 // ... Lots of code here.
 if (!enterKey) {
   // Something has gone wrong here, but it is unclear what.
 }
 ```

 * Don't use `?.` as a way to silence TypeScript "object is possibly null"
   errors. Instead use `assert()` statements. Only use the optional chaining
   feature when the code needs to handle null/undefined gracefully.

 * Don't use `async` if the body of the function does not use `await`. If the
   function indeed needs to return a Promise:

 ```js
 // Don't do this.
 async function hello(): Promise<string> {
   return 'Hello';
 }

 // Do this instead.
 function hello(): Promise<string> {
   return Promise.resolve('Hello');
 }
 ```

 * Don't use the non-null `!` operator unnecessarily, for example when TypeScript
   already knows that a variable can't be null. For example:

 ```js
 // Don't do this. querySelectorAll never returns null.
 let items = document.body.querySelectorAll('div')!;

 // Do this instead.
 let items = document.body.querySelectorAll('div');
 ```

 ### ESLint checks

 A big part of the styleguide is automatically enforced via ESLint checks. There
 are two types of ESLint checks:

 1. **Checks applied at presubmit time**.
    These can be triggered locally with `git cl presubmit --files='path/to/folder/*.ts'`
    and run as part of `git cl upload`.

 2. **Checks applied at build time**. These are type-aware checks, which are more
    sophisticated than the presubmit checks at #1 and must be run as part of the
    build as they require a tsconfig file to work. See [this list](
    https://typescript-eslint.io/rules/?=typeInformation) of all possible such
    checks (not all of these are used in Chromium). Build-time ESLint checks can
    be triggered locally by building the `chrome` or `browser_tests` binaries, or
    by explicitly triggering the `:lint` target for cases where `build_webui()`
    or `build_webui_tests()` is used. For example by running:
    <br><br>
    `autoninja -C out/chromium/ chrome/browser/resources/settings:lint`
    <br><br>
    See [`build_webui()` docs](
    https://chromium.googlesource.com/chromium/src/+/HEAD/docs/webui/webui_build_configuration.md#build_webui)
    for more details.


 ### Closure compiler (legacy ChromeOS Ash code only)

 * Closure compiler can only be used on legacy ChromeOS Ash code. All other
   platforms and new ChromeOS code are required to use TypeScript to add type
   checking.

 * For legacy code using closure, see [Annotating JavaScript for the Closure
   Compiler](https://developers.google.com/closure/compiler/docs/js-for-compiler)
   for @ directives

 * Use the [closure
   compiler](https://chromium.googlesource.com/chromium/src/+/main/docs/closure_compilation.md)
   to identify JS type errors and enforce correct JSDoc annotations.

 * Add a `BUILD.gn` file to any new web UI code directory.

 * Ensure that your `BUILD.gn` file is included in
   `src/BUILD.gn:webui_closure_compile` (or somewhere in its
   deps hierarchy) so that your code is typechecked in an automated way.

 * Type Polymer elements by appending 'Element' to the element name, e.g.
   `/** @type {IronIconElement} */`

 * Use explicit nullability in JSDoc type information
     * Rather than `@type {Object}` use:
         * `{!Object}` for only Object
         * `{!Object|undefined}` for an Object that may be undefined
         * `{?Object}` for Object that may be null
     * Do the same for typedefs and Array (or any other nullable type)

 * Don't add a `.` after template types
     * DO: `Array<number>`
     * DON'T: `Array.<number>`

 * Don't specify string in template object types. That's the only type of key
   `Object` can possibly have.
     * DO: `Object<T>`
     * DON'T: `Object<string, T>`

 * Use template types for any class that supports them, for example:
     * `Array`
     * `CustomEvent`
     * `Map`
     * `Promise`
     * `Set`

 * Use ES5 getters and setters
     * Use `@type` (instead of `@return` or `@param`) for JSDoc annotations on
       getters/setters

 ## Polymer

 ***note
 Lit is now recommended (over Polymer) for any new WebUI development. See
 the Lit section below for additional detail on when to use Lit vs Polymer. The
 guide below still applies for any new or existing Polymer code.
 ***

 Also see the [Google Polymer Style Guide](http://go/polymer-style).

 * Elements with UI should have their HTML in a .html file and logic in a TS file
   with the same name. The HTML template can be imported into the final JS file
   at runtime from a generated JS wrapper file via the getTemplate() function.
   The wrapper file is generated using the html_to_wrapper gn rule:
 ```
   html_to_wrapper("html_wrapper_files") {
     in_files = [ "my_app.html" ]
   }
 ```

 * Use class based syntax for custom elements. Example:
 ```js
 import {PolymerElement} from 'chrome://resources/polymer/v3_0/polymer/polymer_bundled.min.js';
 import {getTemplate} from './my_app.html.js';

 class MyAppElement extends PolymerElement {
   static get is() {
     return 'my-app';
   }

   static get template() {
     return getTemplate();
   }

   static get properties() {
     return {
       foo: String,
     };
   }

   foo: string;
 }

 customElements.define(MyAppElement.is, MyAppElement);
 ```

 * Use a consistent ordering for common methods (or, in legacy code, the
   parameters passed to Polymer()):
     * `is`
     * `behaviors` (legacy code only)
     * `properties` (public, then private)
     * `hostAttributes`
     * `listeners`, `observers`
     * `created`, `ready`, `attached`, `detached`
     * public methods
     * event handlers, computed functions, and private methods

 * Use camelCase for element IDs to simplify local DOM accessors (i.e.
   `this.$.camelCase` instead of `this.$['dash-case']`).

 * Note: In TypeScript, the `this.$.camelCase` accessor requires adding an
   interface:

 ```js
 interface MyAppElement {
   $: {
     camelCase: HTMLElement,
   };
 }
 ```

 * Use `this.foo` instead of `newFoo` arguments when possible in observers,
   property computation methods, and in element instance methods called from
   HTML.

   The signature of the `computeBar()` function in the TS file does not matter,
   so omit parameters there, as they would be unused. What matters is for the
   call site to declare the right properties as dependencies, so that the
   binding correctly triggers whenever it changes.

   ```ts
   static get properties() {
     return {
       foo: {type: Number, value: 42},
       bar: {type: Boolean, computed: 'computeBar(foo)'},
     };
   }

   private computeBar(): boolean {
     return this.derive(this.foo);
   }
   ```

 * Use native `on-click` for click events instead of `on-tap`. 'tap' is a
   synthetic event provided by Polymer for backward compatibility with some
   browsers and is not needed by Chrome.

 * Make good use of the  [`dom-if` template](
 https://www.polymer-project.org/2.0/docs/devguide/templates#dom-if):
   * Consider using `dom-if` to lazily render parts of the DOM that are hidden by
   default. Also consider using [`cr-lazy-render`](
   https://cs.chromium.org/chromium/src/ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js)
   instead.
   * **Only use `dom-if`** if the DOM subtree is non-trivial, defined as:
       * Contains more than 10 native elements, OR
       * Contain **any** custom elements, OR
       * Has many data bindings, OR
       * Includes non-text content (e.g images).

     For trivial DOM subtrees using the HTML [`hidden` attribute](
     https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/hidden)
     yields better performance, than adding a custom `dom-if` element.

 * Do not add new dependencies on `iron-` or `paper-` Polymer elements, styles,
   and behaviors. These are being removed from Chromium. In many cases, Lit-based
   equivalents already exist in `ui/webui/resources/cr_elements` (e.g.
   `cr-collapse` should be used instead of `iron-collapse`). In other cases,
   there is a native solution which should be used instead of the Polymer
   solution (e.g. use `window.matchMedia()` instead of `iron-media-query`).
   Contact the WebUI OWNERS if you are unsure what to use instead of a specific
   Polymer feature. Exceptions:
   * Polymer UIs can use Polymer's `iron-iconset-svg` to avoid adding a
     dependency on Lit, which is required for using `cr-iconset`. Note that
     Polymer UIs can and should use `cr-icon` instead of `iron-icon`, as
     `cr-icon` can be used with icons provided in either an `iron-iconset-svg`
     or a `cr-iconset`.
   * UIs with a compelling use case (i.e. extremely long list of items) may use
     `iron-list`, as a native/Lit equivalent has not yet been developed. Do not
     use `iron-list` for relatively short lists (~20 or fewer items); use
     `dom-repeat` in Polymer code or `items.map(...)` in Lit HTML.

 * Do not add iron-icons dependency to third_party/polymer/.
   * Polymer provides icons via the `iron-icons` library, but importing each of the iconsets means importing hundreds of SVGs, which is unnecessary because Chrome uses only a small subset.
   * Alternatives:
     * Include the SVG in a WebUI page-specific icon file. e.g. `chrome/browser/resources/settings/icons.html`.
     * If reused across multiple WebUI pages, include the SVG in `ui/webui/resources/cr_elements/icons.html` .
   * You may copy the SVG code from [iron-icons files](https://github.com/PolymerElements/iron-icons/blob/master/iron-icons.js).

 ## Lit
 Lit is now recommended (over Polymer) for new WebUI development. Lit should
 generally be used for any new WebUI pages and any new custom elements being
 added to existing pages, with the following exceptions:

 * New custom elements that need to be a direct parent of an `iron-list` can
   use Polymer while a Lit-based alternative is developed.
 * New custom elements in the Settings, Print Preview, and Password Manager UIs
   that need to interact with those pages `prefs` and `model` mechanisms can
   use Polymer, since these mechanisms rely heavily on subproperty observation
   and are unlikely to be migrated to Lit in the near future.

 Further guidance on Lit use in Chromium can be found in a [dedicated doc](https://chromium.googlesource.com/chromium/src/+/HEAD/docs/webui/webui_using_lit.md).

 ## Grit processing

 Grit is a tool that runs at compile time to pack resources together into
 Chromium. Resources are packed from grd files. Most Chromium WebUI resources
 should be located in autogenerated grd files created by the [`generate_grd`](
 https://chromium.googlesource.com/chromium/src/+/main/docs/webui/webui_build_configuration.md#generate_grd)
 gn rule.

 ### Preprocessing

 Sometimes it is helpful to selectively include or exclude code at compile-time.
 This is done using the [`preprocess_if_expr`][preprocess_if_expr_doc] gn rule,
 which processes files for `<if expr>` without running the entire grit resource
 packing process.

 `<if expr>` tags allow conditional logic by evaluating an expression of grit
 variables in a compile-time environment.

 The grit variables are provided to grit through the `defines` argument of
 `preprocess_if_expr` ([sample search][defines_search]). For some widely
 available variables, see [//tools/grit/grit_args.gni][grit_args] and
 [//chrome/common/features.gni][chrome_features].

 These allow conditionally including or excluding code. For example:

 ```ts
 function isWindows(): boolean {
   // <if expr="is_win">
   return true;
   // </if>
   // <if expr="not is_win">
   return false;
   // </if>
 }
 ```

 ***aside
 Note: Preprocessor statements can live in places that surprise linters or
 formatters (for example: a .ts file with an `<if>` in it will make PRESUBMIT
 ESLint checks fail). Putting these language-invalid features inside of comments
 helps alleviate problems with unexpected input.
 ***

 [preprocess_if_expr_doc]: https://chromium.googlesource.com/chromium/src/+/main/docs/webui/webui_build_configuration.md#preprocess_if_expr
 [defines_search]: https://source.chromium.org/search?q=preprocess_if_expr%20defines&ss=chromium
 [grit_args]: https://crsrc.org/c/tools/grit/grit_args.gni?q=_grit_defines
 [chrome_features]: https://crsrc.org/c/chrome/common/features.gni?q=chrome_grit_defines

 #### Example

 The following BUILD.gn example code uses `preprocess_if_expr` to preprocess any
 `<if expr>` in my_app.ts and in the my_app.html, exposing gn variables to Grit.
 It then wraps the html file (see the earlier `html_to_wrapper` example), runs
 the TypeScript compiler on the outputs of this operation and uses the manifest
 from this operation and the `in_files` option to place both the final,
 preprocessed file and a separate (not preprocessed) icon into a generated grd
 file using `generate_grd`:

 ```
 preprocess_folder = "preprocessed"
 preprocess_manifest = "preprocessed_manifest.json"

 preprocess_if_expr("preprocess") {
   defines = ["is_win=$is_win"]
   in_folder = "."
   in_files = [ "my_app.ts", "my_app.html" ]
   out_folder = "$target_gen_dir/$preprocess_folder"
 }

 html_to_wrapper("html_wrapper_files") {
   in_folder = "$target_gen_dir/$preprocess_folder"
   in_files = [ "my_app.html" ]
   out_folder = "$target_gen_dir/$preprocess_folder"
   deps = [":preprocess"]
 }

 # Run TS compiler on the two files:
 ts_library("build_ts") {
   root_dir = "$target_gen_dir/$preprocess_folder"
   out_dir = "$target_gen_dir/tsc"
   tsconfig_base = "tsconfig_base.json"
   in_files = [
     "my_app.html.ts",
     "my_app.ts",
   ]
   deps = [
     "//third_party/polymer/v3_0:library",
     "//ui/webui/resources/js:build_ts",
   ]
   extra_deps = [
     ":preprocess",
     ":html_wrapper_files",
   ]
 }

 # Put the compiled files as well as a separate my_icon.svg file in the grd:
 generate_grd("build_grd") {
   input_files = [ "my_icon.svg" ]
   input_files_base_dir = rebase_path(".", "//")
   deps = [ ":build_ts" ]
   manifest_files = [ "$target_gen_dir/tsconfig.manifest" ]
   grd_prefix = [ "foo" ]
   out_grd = "$target_gen_dir/resources.grd"
 }
 ```

 *** aside
 Note:
 In a few legacy resources, preprocessing is enabled by adding the
 `preprocess="true"` attribute inside of a `.grd` file on `<structure>` and
 `<include>` nodes.
 ***

 ### Inlining resources with Grit (deprecated, don't use)

 `<include src="[path]">` reads the file at `path` and replaces the `<include>`
 tag with the file contents of `[path]`.

 Don't use `<include>` in new JS code;
 [it is being removed](https://docs.google.com/document/d/1Z18WTNv28z5FW3smNEm_GtsfVD2IL-CmmAikwjw3ryo/edit?usp=sharing#heading=h.66ycuu6hfi9n).
 Instead, use JS imports. If there is concern about importing a large number of
 JS files, the optimize_webui build rule supports bundling pages using Rollup.

 Some legacy UIs use Grit to read and inline resources via `flattenhtml="true"`.
 This option should not be used in new code; instead, use JS imports and bundling
 as needed. Icons can also be placed in an iconset, to avoid importing them
 individually.

 *** aside
 Note: The implementation of flattening does HTML parsing and URL detection via
 regular expressions and is not guaranteed to work in all cases. In particular,
 it does not work with any generated resources.
 ***