commit | 67986f36aeea3df5328993980c61dea442f044b2 | [log] [tgz] |
---|---|---|
author | David Dorwin <ddorwin@chromium.org> | Wed Jun 22 22:45:31 2022 |
committer | Copybara-Service <copybara-worker@google.com> | Wed Jun 22 23:32:02 2022 |
tree | a5c84a706538dd471d5a80c1147e9212121949b2 | |
parent | 82b66f51681bcfbeb4fc7f6d5fe18c4319379c20 [diff] |
[base] Unify SysInfo::GetHardwareInfo() implementations Previously, there were 3 implementations with opt-in for each platform. Since the only difference between named platforms is whether the underlying implementation blocks, merge these. Also remove the explicit handling of platforms that don't implement GetHardwareInfoSync(), forcing all platforms to implement it, even if returning an empty object. Bug: 1311066 Change-Id: I3fa3c98286f4cd2b4fa7b7b8b0a035172ff8423d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3708920 Reviewed-by: Wez <wez@chromium.org> Auto-Submit: David Dorwin <ddorwin@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1016873} NOKEYCHECK=True GitOrigin-RevId: 63c9d174109eda54313906f777d91ae694aaf727
Contains a written down set of principles and other information on //base. Please add to it!
Chromium is a very mature project. Most things that are generally useful are already here and things not here aren't generally useful.
The bar for adding stuff to base is that it must have demonstrated wide applicability. Prefer to add things closer to where they're used (i.e. “not base”), and pull into base only when needed. In a project our size, sometimes even duplication is OK and inevitable.
Adding a new logging macro DPVELOG_NE
is not more clear than just writing the stuff you want to log in a regular logging statement, even if it makes your calling code longer. Just add it to your own code.
If the code in question does not need to be used inside base, but will have multiple consumers across the codebase, consider placing it in a new directory under components/ instead.
base is written for the Chromium project and is not intended to be used outside it. Using base outside of src.git is explicitly not supported, and base makes no guarantees about API (or even ABI) stability (like all other code in Chromium). New code that depends on base/ must be in src.git. Code that's not in src.git but pulled in through DEPS (for example, v8) cannot use base.
Owners are added when a contributor has shown the above qualifications and when they express interest. There isn't an upper bound on the number of OWNERS.
Since the primitives provided by //base are used very widely, it is important to ensure they scale to the necessary workloads and perform well under all supported platforms. The base_perftests
target is a suite of synthetic microbenchmarks that measure performance in various scenarios:
Regressions in these benchmarks can generally by caused by 1) operating system changes, 2) compiler version or flag changes or 3) changes in //base code itself.