| commit | e9742a954faef21e926a68841b7b24e8044fc9a0 | [log] [tgz] |
|---|---|---|
| author | Gabriel Charette <gab@chromium.org> | Fri Apr 23 01:41:55 2021 |
| committer | Copybara-Service <copybara-worker@google.com> | Fri Apr 23 01:51:20 2021 |
| tree | ccf6be1af589bd970cb7b4dfac61c8b5e75e166e | |
| parent | b23c851f55fa3133dbebdcced9fc1dc6d9f1e5db [diff] |
[base tracing] Move message pump trace events to disabled-by-default-base These events are useful in some traces but are so high frequency that they fill up the trace buffer too much for generic scenarios. The only event kept is DispatchMessage as this is the native equivalent of RunTask. Moved it to after ProcessPumpReplacementMessage() to avoid a double-event when the first ProcessMessageHelper() processes kMsgHaveWork and recursively invokes itself. R=etienneb@chromium.org, fdoray@chromium.org Bug: 899897 Change-Id: I6895789fcbb15308892a9ab9f8e9ac62ba7b617f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2845112 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#875468} GitOrigin-RevId: ea30813f5e93ab6d15385f0860795dd5b65f93ef
Contains a written down set of principles and other information on //base. Please add to it!
Chromium is a very mature project. Most things that are generally useful are already here and things not here aren't generally useful.
The bar for adding stuff to base is that it must have demonstrated wide applicability. Prefer to add things closer to where they're used (i.e. “not base”), and pull into base only when needed. In a project our size, sometimes even duplication is OK and inevitable.
Adding a new logging macro DPVELOG_NE is not more clear than just writing the stuff you want to log in a regular logging statement, even if it makes your calling code longer. Just add it to your own code.
If the code in question does not need to be used inside base, but will have multiple consumers across the codebase, consider placing it in a new directory under components/ instead.
base is written for the Chromium project and is not intended to be used outside it. Using base outside of src.git is explicitly not supported, and base makes no guarantees about API (or even ABI) stability (like all other code in Chromium). New code that depends on base/ must be in src.git. Code that's not in src.git but pulled in through DEPS (for example, v8) cannot use base.
Owners are added when a contributor has shown the above qualifications and when they express interest. There isn't an upper bound on the number of OWNERS.
Since the primitives provided by //base are used very widely, it is important to ensure they scale to the necessary workloads and perform well under all supported platforms. The base_perftests target is a suite of synthetic microbenchmarks that measure performance in various scenarios:
Regressions in these benchmarks can generally by caused by 1) operating system changes, 2) compiler version or flag changes or 3) changes in //base code itself.