commit | 0febb1cf4bba9222abeb303f4a69a3a2cc376168 | [log] [tgz] |
---|---|---|
author | Arthur Sonzogni <arthursonzogni@chromium.org> | Fri Oct 13 08:06:07 2023 |
committer | Copybara-Service <copybara-worker@google.com> | Fri Oct 13 08:13:08 2023 |
tree | 6dd836f34a9ef8ed30238deddce603b4f0671647 | |
parent | 0bdfefd998df7988ac522353fe70a5a7ba248394 [diff] |
MiraclePtr in Dawn: Set chrome's dawn_partition_alloc_dir Give Dawn the path to the partition_alloc directory, when built inside Chrome. See corresponding Dawn patch: https://dawn-review.googlesource.com/c/dawn/+/141160 Project: https://docs.google.com/document/d/1wz45t0alQthsIU9P7_rQcfQyqnrBMXzrOjSzdQo-V-A/edit Bug: chromium:1464560 Change-Id: I481b53ae6838b655fbdc56273a4c7b89cecd752c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4935271 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1209282} NOKEYCHECK=True GitOrigin-RevId: 12abea26a7fb0c95246abbee1d5950b196a471b3
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.