| commit | 13c0e6551a7d8ee6e1e0edeacf641ac86e809106 | [log] [tgz] |
|---|---|---|
| author | Alan Cutter <alancutter@google.com> | Wed Nov 09 01:10:07 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Wed Nov 09 01:16:34 2022 |
| tree | 44c079c24b4e579cfceb1aa7e0bfb9dad95f6780 | |
| parent | c04e34915a526bcb3ffc41770e9a087bf6e509b3 [diff] |
Revert "Use flag "pdf-use-skia-renderer" to switch PDF viewer's renderer" This reverts commit ba504e872bf30ac4d253f0ee082b87ec63bfba33. Reason for revert: Pixel tests failing on Mac: https://ci.chromium.org/ui/p/chromium/builders/ci/mac12-arm64-rel-tests/3703/test-results?q=ExactID%3Aninja%3A%2F%2Fpdf%3Apdf_unittests%2FPDFiumPageThumbnailTest.GenerateThumbnail%2FAll.1+VHash%3Ae1e83050ba88b6e6 Original change's description: > Use flag "pdf-use-skia-renderer" to switch PDF viewer's renderer > > Link flag "pdf-use-skia-renderer" with PDFiumEngine so that it can > actually switch the renderer type for the PDF viewer upon > initialization. > > This CL also changes PDFiumTestBase and tests derived from it into > parameterized tests so that they can be tested with Skia renderer > enabled: > - For the tests which involve image rendering results comparison, add > the Skia expectations for them. > - Test PDFiumPageImageDataTest.ImageData is currently skipped because > it crashes when Skia renderer is in use. > > Bug: 1379872 > Change-Id: I90d69e8a34e607dc9a049baf9c46d81569976f16 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4000168 > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Nigi <nigi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1068688} Bug: 1379872, 1382605 Change-Id: Ic2a83ba9d13a3577e5c8f6177c7e7f8d318e93a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4014220 Auto-Submit: Alan Cutter <alancutter@google.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Alan Cutter <alancutter@google.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1068917} NOKEYCHECK=True GitOrigin-RevId: c7d9b1208f52256f9167dab5c93350d10de1986c
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.