| commit | 140bed141bdb9192c2b63d424291e9257606bcaf | [log] [tgz] |
|---|---|---|
| author | Keishi Hattori <keishi@chromium.org> | Sun Nov 20 18:59:08 2022 |
| committer | Copybara-Service <copybara-worker@google.com> | Sun Nov 20 19:04:02 2022 |
| tree | 274b0cd83523b36013416028962e1dd3181e014d | |
| parent | 1574f10fe4a17efa7389f2b2be08711396c7bb20 [diff] |
Revert "[BRP] Test enable_backup_ref_ptr_slow_checks temporarily on mac" This reverts commit 6689bf0c09ed480c55464330dcb87eb79b722a22. Reason for revert: Reverting temporary change Original change's description: > [BRP] Test enable_backup_ref_ptr_slow_checks temporarily on mac > > Test enable_backup_ref_ptr_slow_checks build flag and PartitionAllocBackupRefPtr experiment for one Canary release. > The size increase for PartitionRefCount might be a workaround for the bug. > > Bug: 1378822 > Change-Id: I7249ceb5fa8c586747833ffad8ae9587e7b9a4a3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4019078 > Reviewed-by: Bartek Nowierski <bartekn@chromium.org> > Commit-Queue: Keishi Hattori <keishi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1073206} Bug: 1378822 Change-Id: I3f2d13e03a21d5a40a23179d2057c18ae2663d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4040425 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1073849} NOKEYCHECK=True GitOrigin-RevId: 1d26d2d5e5d1e9c9347d0b453d3506361e50bbd8
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.