commit | 16a6b3a64bdefa4fcddd7b7a46e4328735e86718 | [log] [tgz] |
---|---|---|
author | Ada Romanowski <adarom@google.com> | Fri Mar 08 04:56:14 2024 |
committer | Copybara-Service <copybara-worker@google.com> | Fri Mar 08 05:02:16 2024 |
tree | 7a68dcac79262522e12a303ddf33eb39ff880c77 | |
parent | 87493f353a9f3e9764324905812ad127d579ba9d [diff] |
Assert that PartitionAlloc & MiraclePtr are C++20 Assert that PartitionAlloc & MiraclePtr build on C++ no lower than 20. Gate these asserts within a buildflag which allows embedders to opt out of using C++20 manually. Bug: 324978869 Change-Id: I4d23c2b66885c96498fef8ab1651caa8785403d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310100 Reviewed-by: Takashi Sakamoto <tasak@google.com> Commit-Queue: Takashi Sakamoto <tasak@google.com> Auto-Submit: Ada Romanowski <adarom@google.com> Reviewed-by: Mikihito Matsuura <mikt@google.com> Cr-Commit-Position: refs/heads/main@{#1270016} NOKEYCHECK=True GitOrigin-RevId: 56a61ac528aa9049e67c8db99c77c5d0684f20e1
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.