| commit | 189b76115ea6cea0fc8037869b8e5fcbd9c3dd49 | [log] [tgz] |
|---|---|---|
| author | Arthur Sonzogni <arthursonzogni@chromium.org> | Thu Dec 07 09:37:35 2023 |
| committer | Copybara-Service <copybara-worker@google.com> | Thu Dec 07 09:42:27 2023 |
| tree | bed152851bbfe18e2e1e79f22ee6fa44f8985d9b | |
| parent | 7d92b19043b362a66a7c0771acfd698008f8dec5 [diff] |
PA: Remove unused GN imports. I manually analysed what was used from every imports. All appear to be used, except those 2. Since I am working on removing the //build dependency, the useless import are an easy preliminary step. Bug: 1508847 Change-Id: I32d32c752902aabe3e09ada0ab6a90153280a881 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5094759 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/main@{#1234392} NOKEYCHECK=True GitOrigin-RevId: aa0f06005e3561df02c40cdd0bd4ffd1714849b9
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.