commit | 28f4beac31c8c9cc77267f691d15f479d7bd70a5 | [log] [tgz] |
---|---|---|
author | Arthur Sonzogni <arthursonzogni@chromium.org> | Wed Oct 05 14:44:31 2022 |
committer | Copybara-Service <copybara-worker@google.com> | Wed Oct 05 14:53:27 2022 |
tree | 3e525c9f4b52b82c0baff3f6315c73c3d05de673 | |
parent | 757bd39c4ba9588112010107c71a758de8bf93e2 [diff] |
Enable DanglingPtrDetector temporarily (reland 5) It was previously reverted in: https://chromium-review.googlesource.com/c/chromium/src/+/3931864 The issue has been fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/3924571 Bug: 1341550 Change-Id: I9cf90331702ddecd98905085a1a272f131254faf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3932686 Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/main@{#1055275} NOKEYCHECK=True GitOrigin-RevId: edf92a56237b01c0c1e3b4dfe0311f363c05f914
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a “standalone” configuration), and it could be built as part of Chromium. V8 might define a top-level target, //v8:d8 (a simple executable), that should only be built in the standalone configuration. To figure out whether or not it should be in a standalone configuration, v8 can create a file, build_overrides/v8.gni, that contains a variable, build_standalone_d8 = true
. and import it (as import(“//build_overrides/v8.gni”) from its top-level BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would create its own build_overrides/v8.gni file, and in it set build_standalone_d8 = false
.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.